Skip to content

chore: keep maintainer PRs draft through validation (Fixes #491) #492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Karthik Nadig (karthiknadig) merged 1 commit into from
Jul 28, 2026
Merged

chore: keep maintainer PRs draft through validation (Fixes #491) #492

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions .github/agents/Maintainer.agent.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ git commit -m "feat: add Pixi environment detection (Fixes #42)"
git push -u origin feature/issue-N
```

Create a Draft PR via `github/create_pull_request`:
Create a Draft PR via `github/create_pull_request` and keep it draft throughout Copilot review, review fixes, CI, and quality snapshot inspection. Do not mark it ready merely to request review:

- **Title:** Same as commit message (or summarized if multiple commits)
- **Body:** Keep it concise:
Expand Down Expand Up @@ -313,15 +313,17 @@ Before merging, inspect the completed workflow results and PR comments, not just

# Merge & Cleanup

Once review is complete and all checks pass:
Once review is complete, all checks pass, and the quality snapshot is acceptable:

1. **Merge the PR:**
1. **Mark the PR ready:** Transition out of draft only now, immediately before merge or enabling auto-merge.

2. **Merge the PR:**

```
github/merge_pull_request
```

2. **Delete the feature branch:**
3. **Delete the feature branch:**

```powershell
git checkout main; git pull
Expand All @@ -332,11 +334,11 @@ Once review is complete and all checks pass:

Skip `git push origin --delete <branch>` if GitHub already auto-deleted the remote branch.

3. **Verify the merge postcondition:** Run `gh pr view N --json state,mergedAt,autoMergeRequest` after requesting merge or auto-merge. Do not treat a zero exit code as sufficient; require `state` to be `MERGED` with `mergedAt` populated, or `autoMergeRequest` to be populated when required checks are still pending.
4. **Verify the merge postcondition:** Run `gh pr view N --json state,mergedAt,autoMergeRequest` after requesting merge or auto-merge. Do not treat a zero exit code as sufficient; require `state` to be `MERGED` with `mergedAt` populated, or `autoMergeRequest` to be populated when required checks are still pending.

4. **CI triggers:** Push to main runs the full CI pipeline (builds, tests, artifact uploads).
5. **CI triggers:** Push to main runs the full CI pipeline (builds, tests, artifact uploads).

5. **Continuous maintenance mode:** When the user explicitly asks for autonomous continuation, refresh the open issue/PR queue after cleanup, select the highest-impact ready issue with no overlapping PR, and restart the Development Phase. Do not yield merely because one PR merged. Auto-merge remains opt-in and may be enabled only when the user has explicitly requested it.
6. **Continuous maintenance mode:** When the user explicitly asks for autonomous continuation, refresh the open issue/PR queue after cleanup, select the highest-impact ready issue with no overlapping PR, and restart the Development Phase. Do not yield merely because one PR merged. Auto-merge remains opt-in and may be enabled only when the user has explicitly requested it.

---

Expand Down
Loading