test: isolate missing-env reporting state (Fixes #500)

[Karthik Nadig (karthiknadig)]

Summary

• inject missing-env reporting atomics into the state-machine helpers
• keep production wrappers on the process-global state
• give each unit test an independent local atomic instead of a shared mutex/global
• prevent configure tests from racing or poisoning missing-env tests

Validation

• 20 consecutive cargo test -p pet --bin pet --quiet runs
• .\scripts\rust-precommit.ps1

Fixes #500

[github-actions]

Performance Report (Linux) ➖

Metric	PR (P50)	PR (P95)	Baseline (P50)	Delta	Change
Server Startup	1ms	1ms	1ms	0ms	0%
Full Refresh	57ms	189ms	55ms	2ms	0%

Results based on 10 iterations. P50 = median, P95 = 95th percentile.

---

Legend

• 🚀 Significant speedup (>100ms faster)
• ✅ Faster than baseline
• ➖ No significant change
• 🔺 Slower than baseline (>100ms)
• ⚠️ Significant slowdown (>500ms)

[github-actions]

Performance Report (macOS)

Metric	PR (P50)	PR (P95)	Baseline (P50)	Delta
Server Startup	101ms	616ms	69ms	32ms
Full Refresh	172ms	30259ms	118ms	54ms

Results based on 10 iterations. P50 = median, P95 = 95th percentile.

---

Legend

• 🚀 Significant speedup (>100ms faster)
• ✅ Faster than baseline
• ➖ No significant change
• 🔺 Slower than baseline (>100ms)
• ⚠️ Significant slowdown (>500ms)

[github-actions]

Test Coverage Report (Linux)

Metric	Value
Current Coverage	80.6%
Base Branch Coverage	80.6%
Delta	0% ➖

---

Coverage unchanged.

[github-actions]

Performance Report (Windows) ➖

Metric	PR (P50)	PR (P95)	Baseline (P50)	Delta	Change
Server Startup	9ms	12ms	9ms	0ms	0%
Full Refresh	165ms	567ms	164ms	1ms	0.6%

Results based on 10 iterations. P50 = median, P95 = 95th percentile.

---

Legend

• 🚀 Significant speedup (>100ms faster)
• ✅ Faster than baseline
• ➖ No significant change
• 🔺 Slower than baseline (>100ms)
• ⚠️ Significant slowdown (>500ms)

[github-actions]

Test Coverage Report (Windows)

Metric	Value
Current Coverage	77.24%
Base Branch Coverage	77.31%
Delta	-0.07% ❌

---

Coverage decreased. Please add tests for new code.

[Copilot]

🟢 Ready to approve

The changes align with the issue acceptance criteria and cleanly isolate test state while preserving production behavior via wrappers over the existing global atomic.

This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.

Pull request overview

This PR reduces test flakiness around missing-environment reporting in pet::jsonrpc by extracting the missing-env reporting state-machine helpers to accept an injected AtomicU64, while keeping production behavior backed by the existing process-global atomic. Tests are updated to use per-test local atomics, removing the need for a shared test mutex and preventing cross-test interference with configure-related state changes.

Changes:

• Added *_with_state variants for missing-env reporting helpers that accept an injected &AtomicU64, with thin production wrappers continuing to use MISSING_ENVS_REPORTING_STATE.
• Removed the global MISSING_ENVS_TEST_LOCK and updated missing-env-reporting unit tests to use independent local AtomicU64 instances.
• Adjusted the configure-reset test to validate the reset behavior using the injected state rather than process-global state.

File summaries

File	Description
crates/pet/src/jsonrpc.rs	Extracts missing-env reporting state-machine helpers to accept injected atomics and updates unit tests to avoid shared process-global state.

Review details

• Files reviewed: 1/1 changed files
• Comments generated: 0
• Review effort level: Lite

We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.