Consolidate samples, run notebooks in build#1070
Merged
Merged
Conversation
This change consolidates our samples under the top level samples folder by moving the three notebooks that were under pip/samples. It also adds a new build step controlled by `--notebooks` that uses a virtual python environment to run the notebooks and verify the cells execute successfully. It does not verify the contents of the output, that can come in a later PR.
Collaborator
Author
|
This helps address part of #1023 |
Benchmark for aff6ccfClick to view benchmark
|
Benchmark for 47d1e09Click to view benchmark
|
Benchmark for 38991ddClick to view benchmark
|
minestarks
requested changes
Jan 25, 2024
Member
minestarks
left a comment
There was a problem hiding this comment.
Just some thoughts about structuring the build scripts.
minestarks
reviewed
Jan 25, 2024
swernli
commented
Jan 25, 2024
Benchmark for 915431fClick to view benchmark
|
Benchmark for 0d5a596Click to view benchmark
|
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Jan 26, 2024
When a `%%qsharp` cell throws a compiler or runtime error, the whole should be marked as an error, just as when Python code throws an exception. Related: #1070 . When we test notebooks in automation, we want to catch any failures in Q# cells. VS Code before/after side by side:  Jupyter notebook before/after side by side: 
Benchmark for 052dbd9Click to view benchmark
|
DmitryVasilevsky
approved these changes
Jan 31, 2024
cesarzc
approved these changes
Jan 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change consolidates our samples under the top level samples folder by moving the three notebooks that were under pip/samples.
It also adds a new build step controlled by
--notebooksthat uses a virtual python environment to run the notebooks and verify the cells execute successfully. It does not verify the contents of the output, that can come in a later PR.