%%qsharp cell failures should mark the cell as failed#1071
Merged
Conversation
swernli
approved these changes
Jan 24, 2024
Benchmark for 966d9afClick to view benchmark
|
Benchmark for fea2cccClick to view benchmark
|
idavis
approved these changes
Jan 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a
%%qsharpcell throws a compiler or runtime error, the whole should be marked as an error, just as when Python code throws an exception.Related: #1070 . When we test notebooks in automation, we want to catch any failures in Q# cells.
VS Code before/after side by side:
Jupyter notebook before/after side by side: