Enhance variable arity functions to accept optional parameters across multiple components#3419
Merged
Conversation
… multiple components - Updated `space`, `time`, `error_rate`, and related methods in Rust and Python to accept an optional `params` argument, e.g., concrete rotation angles from a rotation instruction in a trace. - Modified the `generic_function` to handle callables with an additional `params` argument. - Added tests to verify functionality with the new parameter handling in both Python and Rust.
msoeken
requested review from
billti,
brad-lackey,
idavis and
minestarks
as code owners
brad-lackey
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
space,time,error_rate, and related methods in Rust and Python to accept an optionalparamsargument, e.g., concrete rotation angles from a rotation instruction in a trace.generic_functionto handle callables with an additionalparamsargument.