fix(ci): use mapped upstream version for Hermes version marker#2933
Merged
Saadnajmi merged 1 commit intomicrosoft:mainfrom Apr 18, 2026
Merged
fix(ci): use mapped upstream version for Hermes version marker#2933Saadnajmi merged 1 commit intomicrosoft:mainfrom
Saadnajmi merged 1 commit intomicrosoft:mainfrom
Conversation
Saadnajmi
force-pushed
the
fix/hermes-version-marker
branch
2 times, most recently
from
6d0a1a1 to
98179d4
Compare
The version marker was using package.json version (e.g. 0.81.7) but prepareHermesArtifactsAsync resolves via peerDependencies (e.g. 0.81.6). The mismatch caused the setup step to delete our prebuilt Hermes artifacts and re-download from Maven, which lacks macOS slices in the universal xcframework. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Saadnajmi
force-pushed
the
fix/hermes-version-marker
branch
from
98179d4 to
983d546
Compare
hansenyy
approved these changes
Apr 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
package.jsonversion (e.g.0.81.7) butprepareHermesArtifactsAsyncresolves viapeerDependencies(e.g.0.81.6).prepareHermesArtifactsAsync.Test plan
🤖 Generated with Claude Code