Skip to content

fix: Wrong pods get installed with release candidates #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 25, 2020
Merged

fix: Wrong pods get installed with release candidates #133

merged 1 commit into from
Jun 25, 2020

Conversation

@tido64
Copy link
Member

@tido64 tido64 commented Jun 25, 2020

No description provided.

@tido64 tido64 requested a review from alloy June 25, 2020 00:19
@tido64 tido64 self-assigned this Jun 25, 2020
@tido64 tido64 force-pushed the tido/add-more-tests branch from be51b81 to cbaf494 Compare June 25, 2020 00:20
@tido64 tido64 force-pushed the tido/add-more-tests branch from cbaf494 to 3e091e6 Compare June 25, 2020 08:17
alloy
alloy approved these changes Jun 25, 2020
View reviewed changes
Copy link
Member

@alloy alloy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice test coverage 👌 ✨

@tido64 tido64 merged commit d59864f into master Jun 25, 2020
@tido64 tido64 deleted the tido/add-more-tests branch June 25, 2020 11:10
@tido64
Copy link
Member Author

tido64 commented Jun 25, 2020 •
edited
Loading

@alloy: I'm having issues adding tests for resolve_module (and all the functions calling it) because it makes a call to Pod::Executable.execute_command. I'm reluctant to replace it just so we can add tests. Do you have any ideas?

@tido64
Copy link
Member Author

tido64 commented Jun 25, 2020

🎉 This PR is included in version 0.1.16 🎉

The release is available on:

Your semantic-release bot 📦🚀

@alloy
Copy link
Member

alloy commented Jun 25, 2020

@tido64 minitest comes with mocking and stubbing facilities.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@alloy alloy alloy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@tido64 tido64

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tido64 @alloy