Update Node to v16#11500
Conversation
|
doesn't the setup script need to be updated too? |
|
/azp run |
|
Azure Pipelines failed to run 1 pipeline(s). |
| @{ | ||
| Id=[CheckId]::Node; | ||
| Name = 'Node.js (LTS, >= 14.0)'; | ||
| Name = 'Node.js (LTS, >= 16.0)'; |
There was a problem hiding this comment.
You also need to update the CheckNode function
| - name: versions | ||
| type: object | ||
| default: [14, 16] | ||
| default: [16] |
There was a problem hiding this comment.
We might want to add node 18 in here since it's been LTS for a long time now
There was a problem hiding this comment.
Node.js is about to release version 20.
There was a problem hiding this comment.
We should definitely add 20 when it's out and see if there's any problems as new devs will probably install 20 by default
There was a problem hiding this comment.
Addition of 18 threw errors in the testing. Looks like there's an API that is no longer available on 18 that we use. I'll file an issue to track addressing that.
There was a problem hiding this comment.
You know, that sounds familliar - something that changed at like 18.5 or something.
jonthysell
left a comment
jonthysell
left a comment
There was a problem hiding this comment.
Once you at least update the dep script it should be good to go.
| - name: versions | ||
| type: object | ||
| default: [14, 16] | ||
| default: [16] |
There was a problem hiding this comment.
You know, that sounds familliar - something that changed at like 18.5 or something.
|
Bump babel config as well? |
Summary: **NOTE**: This is a **BREAKING** change. TLDR; Enforce minimum Node.js v16 in all RN packages. This diff **Updates Node.js to v16** across all RN packages. #### Context: - For RN development and new project created; bump to node 16 was in #36217 - Recently `react-native-windows` also; updated node to v16, microsoft/react-native-windows#11500 #### Changes: - [BREAKING] Update Node.js to v16 across all RN packages under 'packages/' dir ## Changelog: [GENERAL][BREAKING] - Update Node.js to v16 in all RN packages Pull Request resolved: #37073 Test Plan: - `yarn lint && yarn flow && yarn test-ci` --> _should be green_ Reviewed By: cipolleschi Differential Revision: D45306108 Pulled By: jacdebug fbshipit-source-id: e3ba7d0151b86a6a0a3d63fb29c2bd887e1ac1e7
5 participants
Description
Type of Change
Why
Upgrade Node to v16. Upstream is making the same update for v72.
Resolves #11451
Microsoft Reviewers: Open in CodeFlow