Skip to content

Update Node to v16 #11500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chiaramooney merged 11 commits into from
Apr 24, 2023
Merged

Update Node to v16 #11500

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
f0fc59d
Update Node to 16
chiaramooney Apr 13, 2023
329f79f
Change files
chiaramooney Apr 13, 2023
b7e18f4
Merge branch 'main' of https://github.com/microsoft/react-native-wind…
chiaramooney Apr 14, 2023
e02c2cc
Resolve Yarn Build Errors
chiaramooney Apr 14, 2023
8f7e079
Fix Additional References
chiaramooney Apr 14, 2023
230793f
Retrigger Pipeline
chiaramooney Apr 17, 2023
acd58fa
Change Syntax
chiaramooney Apr 17, 2023
b857305
Merge branch 'main' of https://github.com/microsoft/react-native-wind…
chiaramooney Apr 18, 2023
fb0dee9
Merge branch 'main' of https://github.com/microsoft/react-native-wind…
chiaramooney Apr 20, 2023
d7b4551
Address Feedback
chiaramooney Apr 20, 2023
ec4f9e7
Revert
chiaramooney Apr 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .ado/jobs/node-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ parameters:

- name: versions
type: object
default: [14, 16]
default: [16]
Copy link
Copy Markdown
Contributor

@jonthysell jonthysell Apr 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to add node 18 in here since it's been LTS for a long time now

Copy link
Copy Markdown
Member

@vmoroz vmoroz Apr 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Node.js is about to release version 20.

Copy link
Copy Markdown
Contributor

@jonthysell jonthysell Apr 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should definitely add 20 when it's out and see if there's any problems as new devs will probably install 20 by default

Copy link
Copy Markdown
Contributor Author

@chiaramooney chiaramooney Apr 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addition of 18 threw errors in the testing. Looks like there's an API that is no longer available on 18 that we use. I'll file an issue to track addressing that.

Copy link
Copy Markdown
Contributor

@jonthysell jonthysell Apr 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You know, that sounds familliar - something that changed at like 18.5 or something.


jobs:
- ${{ each nodeVersion in parameters.versions }}:
Expand Down
7 changes: 7 additions & 0 deletions change/@office-iss-react-native-win32-ab60d8d7-ccd1-46ef-84f2-b2bb7e2c2141.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "prerelease",
"comment": "Update Node to 16",
"packageName": "@office-iss/react-native-win32",
"email": "34109996+chiaramooney@users.noreply.github.com",
"dependentChangeType": "patch"
}
7 changes: 7 additions & 0 deletions change/@react-native-windows-automation-7976a61f-7ebb-4a67-9f81-047f6e386565.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "Update Node to 16",
"packageName": "@react-native-windows/automation",
"email": "34109996+chiaramooney@users.noreply.github.com",
"dependentChangeType": "patch"
}
7 changes: 7 additions & 0 deletions change/@react-native-windows-automation-channel-f520bf36-957e-4117-9011-25c50fc968e1.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "Update Node to 16",
"packageName": "@react-native-windows/automation-channel",
"email": "34109996+chiaramooney@users.noreply.github.com",
"dependentChangeType": "patch"
}
7 changes: 7 additions & 0 deletions change/@react-native-windows-automation-commands-001324e2-d082-4d1d-8647-6c03b6a86f5c.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "Update Node to 16",
"packageName": "@react-native-windows/automation-commands",
"email": "34109996+chiaramooney@users.noreply.github.com",
"dependentChangeType": "patch"
}
7 changes: 7 additions & 0 deletions change/@react-native-windows-cli-f1bba592-2e4a-40cf-a6ad-fbd8376ca0b4.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "prerelease",
"comment": "Update Node to 16",
"packageName": "@react-native-windows/cli",
"email": "34109996+chiaramooney@users.noreply.github.com",
"dependentChangeType": "patch"
}
7 changes: 7 additions & 0 deletions change/@react-native-windows-codegen-d46d93a9-fc33-4d13-8a45-1875bf0ca9f6.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "prerelease",
"comment": "Update Node to 16",
"packageName": "@react-native-windows/codegen",
"email": "34109996+chiaramooney@users.noreply.github.com",
"dependentChangeType": "patch"
}
7 changes: 7 additions & 0 deletions change/@react-native-windows-find-repo-root-ff7a0e59-80a6-4ba4-860a-127891ca03b2.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "prerelease",
"comment": "Update Node to 16",
"packageName": "@react-native-windows/find-repo-root",
"email": "34109996+chiaramooney@users.noreply.github.com",
"dependentChangeType": "patch"
}
7 changes: 7 additions & 0 deletions change/@react-native-windows-fs-a8ed4cf5-8949-458e-a074-02ba6e224da9.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "prerelease",
"comment": "Update Node to 16",
"packageName": "@react-native-windows/fs",
"email": "34109996+chiaramooney@users.noreply.github.com",
"dependentChangeType": "patch"
}
7 changes: 7 additions & 0 deletions change/@react-native-windows-package-utils-7fdeabb4-bf88-45ce-b389-a7806a90d1b1.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "prerelease",
"comment": "Update Node to 16",
"packageName": "@react-native-windows/package-utils",
"email": "34109996+chiaramooney@users.noreply.github.com",
"dependentChangeType": "patch"
}
7 changes: 7 additions & 0 deletions change/@react-native-windows-telemetry-5a412b23-d4f6-4b91-a36f-c059ce452619.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "prerelease",
"comment": "Update Node to 16",
"packageName": "@react-native-windows/telemetry",
"email": "34109996+chiaramooney@users.noreply.github.com",
"dependentChangeType": "patch"
}
7 changes: 7 additions & 0 deletions change/@rnw-scripts-babel-node-config-30bcf3d8-e1ea-4002-8971-3070efe3a769.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "Update Node to 16",
"packageName": "@rnw-scripts/babel-node-config",
"email": "34109996+chiaramooney@users.noreply.github.com",
"dependentChangeType": "patch"
}
7 changes: 7 additions & 0 deletions change/@rnw-scripts-create-github-releases-d359f93e-956a-4347-a72b-d0b6947ddb88.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "Update Node to 16",
"packageName": "@rnw-scripts/create-github-releases",
"email": "34109996+chiaramooney@users.noreply.github.com",
"dependentChangeType": "patch"
}
7 changes: 7 additions & 0 deletions change/@rnw-scripts-doxysaurus-607e9b54-a415-44b0-a80a-55cfc5d96b3b.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "Update Node to 16",
"packageName": "@rnw-scripts/doxysaurus",
"email": "34109996+chiaramooney@users.noreply.github.com",
"dependentChangeType": "patch"
}
7 changes: 7 additions & 0 deletions change/@rnw-scripts-eslint-config-0614bf2c-93a5-4230-8cdf-21b2dc0a98f4.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "Update Node to 16",
"packageName": "@rnw-scripts/eslint-config",
"email": "34109996+chiaramooney@users.noreply.github.com",
"dependentChangeType": "patch"
}
7 changes: 7 additions & 0 deletions change/@rnw-scripts-format-files-bcace8af-bb55-4e1d-acc0-142ef047c2a7.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "Update Node to 16",
"packageName": "@rnw-scripts/format-files",
"email": "34109996+chiaramooney@users.noreply.github.com",
"dependentChangeType": "patch"
}
7 changes: 7 additions & 0 deletions change/@rnw-scripts-integrate-rn-a66d55d6-cf32-4192-8a11-ddb22586342e.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "Update Node to 16",
"packageName": "@rnw-scripts/integrate-rn",
"email": "34109996+chiaramooney@users.noreply.github.com",
"dependentChangeType": "patch"
}
7 changes: 7 additions & 0 deletions change/@rnw-scripts-jest-debug-config-94b9edd7-379b-4b41-85cf-196fc7cd161f.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "Update Node to 16",
"packageName": "@rnw-scripts/jest-debug-config",
"email": "34109996+chiaramooney@users.noreply.github.com",
"dependentChangeType": "patch"
}
7 changes: 7 additions & 0 deletions change/@rnw-scripts-jest-e2e-config-c96567af-de76-44b6-ab20-dafd560704d0.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "Update Node to 16",
"packageName": "@rnw-scripts/jest-e2e-config",
"email": "34109996+chiaramooney@users.noreply.github.com",
"dependentChangeType": "patch"
}
7 changes: 7 additions & 0 deletions change/@rnw-scripts-jest-out-of-tree-resolver-4d790491-7071-4ba8-814f-a63f8a9fd8be.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "Update Node to 16",
"packageName": "@rnw-scripts/jest-out-of-tree-resolver",
"email": "34109996+chiaramooney@users.noreply.github.com",
"dependentChangeType": "patch"
}
7 changes: 7 additions & 0 deletions ...@rnw-scripts-jest-out-of-tree-snapshot-resolver-a936a881-2d0b-4fe6-ab10-ec61cf0df18f.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "Update Node to 16",
"packageName": "@rnw-scripts/jest-out-of-tree-snapshot-resolver",
"email": "34109996+chiaramooney@users.noreply.github.com",
"dependentChangeType": "patch"
}
7 changes: 7 additions & 0 deletions change/@rnw-scripts-jest-unittest-config-a16998bb-5302-42d8-a076-922d06ab6d4a.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "Update Node to 16",
"packageName": "@rnw-scripts/jest-unittest-config",
"email": "34109996+chiaramooney@users.noreply.github.com",
"dependentChangeType": "patch"
}
7 changes: 7 additions & 0 deletions change/@rnw-scripts-just-task-994c0e38-acb7-4ebe-9323-47874efe46eb.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "Update Node to 16",
"packageName": "@rnw-scripts/just-task",
"email": "34109996+chiaramooney@users.noreply.github.com",
"dependentChangeType": "patch"
}
7 changes: 7 additions & 0 deletions change/@rnw-scripts-promote-release-461568f1-f610-43cb-8107-6b0e6783fc73.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "Update Node to 16",
"packageName": "@rnw-scripts/promote-release",
"email": "34109996+chiaramooney@users.noreply.github.com",
"dependentChangeType": "patch"
}
7 changes: 7 additions & 0 deletions change/@rnw-scripts-take-screenshot-355529e6-b230-494c-b08d-4cb151a1ba03.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "Update Node to 16",
"packageName": "@rnw-scripts/take-screenshot",
"email": "34109996+chiaramooney@users.noreply.github.com",
"dependentChangeType": "patch"
}
7 changes: 7 additions & 0 deletions change/@rnw-scripts-ts-config-02fbb14e-88fb-4574-8d66-1ad594f5fad3.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "Update Node to 16",
"packageName": "@rnw-scripts/ts-config",
"email": "34109996+chiaramooney@users.noreply.github.com",
"dependentChangeType": "patch"
}
7 changes: 7 additions & 0 deletions change/react-native-platform-override-b7f4fb32-c92f-4f03-a725-2e587d0ed42b.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "Update Node to 16",
"packageName": "react-native-platform-override",
"email": "34109996+chiaramooney@users.noreply.github.com",
"dependentChangeType": "patch"
}
7 changes: 7 additions & 0 deletions change/react-native-windows-c871d835-f06f-4777-b7e1-52629cb70952.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "prerelease",
"comment": "Update Node to 16",
"packageName": "react-native-windows",
"email": "34109996+chiaramooney@users.noreply.github.com",
"dependentChangeType": "patch"
}
7 changes: 7 additions & 0 deletions change/react-native-windows-init-0e37772a-b2fe-4025-b40a-c2bddc0d6b3a.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "Update Node to 16",
"packageName": "react-native-windows-init",
"email": "34109996+chiaramooney@users.noreply.github.com",
"dependentChangeType": "patch"
}
6 changes: 3 additions & 3 deletions packages/@office-iss/react-native-win32-tester/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,14 +27,14 @@
"@rnw-scripts/eslint-config": "1.1.15",
"@rnw-scripts/just-task": "2.3.6",
"@rnw-scripts/ts-config": "2.0.3",
"@types/node": "^14.14.22",
"@types/node": "^16.0.0",
"eslint": "^8.19.0",
"just-scripts": "^1.3.3",
"react-native": "0.0.0-20230404-2109-62c4da142",
"react-native-platform-override": "^1.9.4",
"typescript": "^4.9.5"
},
"engines": {
"node": ">= 14"
"node": ">= 16"
}
}
}
6 changes: 3 additions & 3 deletions packages/@office-iss/react-native-win32/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@
"@rnw-scripts/just-task": "2.3.6",
"@rnw-scripts/metro-dev-config": "0.0.0",
"@rnx-kit/jest-preset": "^0.1.0",
"@types/node": "^14.14.22",
"@types/node": "^16.0.0",
"@types/prop-types": "15.7.1",
"@types/react": "^18.0.18",
"eslint": "^8.19.0",
Expand All @@ -100,6 +100,6 @@
},
"promoteRelease": true,
"engines": {
"node": ">= 14"
"node": ">= 16"
}
}
}
6 changes: 3 additions & 3 deletions ...ages/@office-iss/react-native-win32/src/Libraries/Components/Touchable/TouchableWin32.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,9 +180,9 @@ const LONG_PRESS_ALLOWED_MOVEMENT = 10;
* (that use internal state to conditionally calculate styles)
*/
export class TouchableWin32 extends React.Component<ITouchableWin32Props, IInternalTouchableWin32State> {
private _longPressDelayTimeout: number;
private _touchableDelayTimeout: number;
private _pressOutDelayTimeout: number;
private _longPressDelayTimeout: NodeJS.Timeout;
private _touchableDelayTimeout: NodeJS.Timeout;
private _pressOutDelayTimeout: NodeJS.Timeout;
private _pressInLocation: IPressInLocation;
private _touchState: IState;
private _responderID: number;
Expand Down
6 changes: 3 additions & 3 deletions packages/@react-native-windows/automation-channel/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
"@rnw-scripts/just-task": "2.3.6",
"@rnw-scripts/ts-config": "2.0.3",
"@types/find-up": "^4.0.0",
"@types/node": "^14.14.22",
"@types/node": "^16.0.0",
"eslint": "^8.19.0",
"just-scripts": "^1.3.2",
"prettier": "^2.4.1",
Expand All @@ -40,6 +40,6 @@
"windows"
],
"engines": {
"node": ">= 14"
"node": ">= 16"
}
}
}
6 changes: 3 additions & 3 deletions packages/@react-native-windows/automation-commands/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
"@rnw-scripts/just-task": "2.3.6",
"@rnw-scripts/ts-config": "2.0.3",
"@types/jest": "^29.2.2",
"@types/node": "^14.14.22",
"@types/node": "^16.0.0",
"eslint": "^8.19.0",
"prettier": "^2.4.1",
"typescript": "^4.9.5"
Expand All @@ -38,6 +38,6 @@
"README.md"
],
"engines": {
"node": ">= 14"
"node": ">= 16"
}
}
}
6 changes: 3 additions & 3 deletions packages/@react-native-windows/automation/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
"@rnw-scripts/just-task": "2.3.6",
"@rnw-scripts/ts-config": "2.0.3",
"@types/jest": "^29.2.2",
"@types/node": "^14.14.22",
"@types/node": "^16.0.0",
"@types/readline-sync": "^1.4.4",
"eslint": "^8.19.0",
"prettier": "^2.4.1",
Expand All @@ -49,6 +49,6 @@
"README.md"
],
"engines": {
"node": ">= 14"
"node": ">= 16"
}
}
}
6 changes: 3 additions & 3 deletions packages/@react-native-windows/cli/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
"@types/jest": "^29.2.2",
"@types/lodash": "^4.14.168",
"@types/mustache": "^4.1.1",
"@types/node": "^14.14.22",
"@types/node": "^16.0.0",
"@types/ora": "^3.2.0",
"@types/prompts": "2.0.10",
"@types/semver": "^7.3.3",
Expand Down Expand Up @@ -84,6 +84,6 @@
"promoteRelease": true,
"windowsOnly": true,
"engines": {
"node": ">= 14"
"node": ">= 16"
}
}
}
6 changes: 3 additions & 3 deletions packages/@react-native-windows/codegen/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
"@rnw-scripts/ts-config": "2.0.3",
"@types/chalk": "^2.2.0",
"@types/jest": "^29.2.2",
"@types/node": "^14.14.22",
"@types/node": "^16.0.0",
"@types/yargs": "16.0.0",
"@typescript-eslint/eslint-plugin": "^5.30.5",
"@typescript-eslint/parser": "^5.30.5",
Expand Down Expand Up @@ -66,6 +66,6 @@
},
"promoteRelease": true,
"engines": {
"node": ">= 14"
"node": ">= 16"
}
}
}
6 changes: 3 additions & 3 deletions packages/@react-native-windows/find-repo-root/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
"@rnw-scripts/just-task": "2.3.6",
"@rnw-scripts/ts-config": "2.0.3",
"@types/find-up": "^4.0.0",
"@types/node": "^14.14.22",
"@types/node": "^16.0.0",
"@typescript-eslint/eslint-plugin": "^5.30.5",
"@typescript-eslint/parser": "^5.30.5",
"eslint": "^8.19.0",
Expand All @@ -44,6 +44,6 @@
"lib-commonjs"
],
"engines": {
"node": ">= 14"
"node": ">= 16"
}
}
}
Loading