Skip to content

[FIX] Web mobile: can't press after a long press#1081

Merged
erictraut merged 2 commits intomicrosoft:masterfrom
dagatsoin:fix/mobile-long-press-prevents-next-press-event
Apr 16, 2019
Merged

[FIX] Web mobile: can't press after a long press#1081
erictraut merged 2 commits intomicrosoft:masterfrom
dagatsoin:fix/mobile-long-press-prevents-next-press-event

Conversation

@dagatsoin
Copy link
Copy Markdown
Contributor

@dagatsoin dagatsoin commented Apr 16, 2019

Issue

Current behavior
User cannot press button again just after a long press. The user mush do a double tap as a workaround.
This can be reproducted on the current test app on the long press button test on web mobile:
1- do a long press, the "Long press count" increases
2- do a press, the "Press count" does not change
3- do a press again, the "Press count" increases.

Expected behavior
1- do a long press, the "Long press count" should increase
2- do a press, the "Press count" should increase

Fix

This PR does the following.

  • reflect the behavior of desktop: the onMouseUp event after a longPress is canceled and the _ignoreClick flag is reset.

QA

1- do a long press, the "Long press count" should increase
2- do a press, the "Press count" should increase

@erictraut
Copy link
Copy Markdown
Contributor

Looks good. Thanks!

@erictraut erictraut merged commit a732419 into microsoft:master Apr 16, 2019
@dagatsoin dagatsoin deleted the fix/mobile-long-press-prevents-next-press-event branch April 16, 2019 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants