[FIX] Web mobile: can't press after a long press#1081
Merged
erictraut merged 2 commits intomicrosoft:masterfrom Apr 16, 2019
Merged
Conversation
Contributor
|
Looks good. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Current behavior
User cannot press button again just after a long press. The user mush do a double tap as a workaround.
This can be reproducted on the current test app on the long press button test on web mobile:
1- do a long press, the "Long press count" increases
2- do a press, the "Press count" does not change
3- do a press again, the "Press count" increases.
Expected behavior
1- do a long press, the "Long press count" should increase
2- do a press, the "Press count" should increase
Fix
This PR does the following.
QA
1- do a long press, the "Long press count" should increase
2- do a press, the "Press count" should increase