Skip to content

[FIX] Web mobile: can't press after a long press #1081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erictraut merged 2 commits into from
Apr 16, 2019
Merged

[FIX] Web mobile: can't press after a long press #1081

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c26911f
Web mobile: stop propagation of onMouseUp after a longPress
dagatsoin Apr 16, 2019
98c98f8
fix regression on desktop
dagatsoin Apr 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/web/Button.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ export class Button extends ButtonBase {

private _mountedButton: HTMLButtonElement | null = null;
private _lastMouseDownEvent: Types.SyntheticEvent | undefined;
private _ignoreMouseUp = false;
private _ignoreClick = false;
private _longPressTimer: number | undefined;
private _isMouseOver = false;
Expand Down Expand Up @@ -210,13 +211,21 @@ export class Button extends ButtonBase {
if (this.props.onLongPress) {
// lastMouseDownEvent can never be undefined at this point
this.props.onLongPress(this._lastMouseDownEvent!);
this._ignoreMouseUp = true;
this._ignoreClick = true;
}
}, this.props.delayLongPress || _longPressTime);
}
}

private _onMouseUp = (e: Types.SyntheticEvent) => {
private _onMouseUp = (e: Types.SyntheticEvent | Types.TouchEvent) => {
if (this._ignoreMouseUp) {
e.stopPropagation();
// Touch event won't trigger onClick when a long press is released. So we reset the ignore flag here.
if ('touches' in e) {
this._ignoreClick = false;
}
}
if (this.props.onPressOut) {
this.props.onPressOut(e);
}
Expand Down