feat(packetparser): break down parsed packets and conntrack GCed entries by reason - #2505
Open
Matthew McKeen (mmckeen) wants to merge 5 commits into
Open
feat(packetparser): break down parsed packets and conntrack GCed entries by reason#2505Matthew McKeen (mmckeen) wants to merge 5 commits into
Matthew McKeen (mmckeen) wants to merge 5 commits into
Conversation
Matthew McKeen (mmckeen)
marked this pull request as ready for review
July 9, 2026 02:31
Matthew McKeen (mmckeen)
requested review from
skosuri1 and
Timothy J. Raymond (timraymond)
July 9, 2026 02:31
Matthew McKeen (mmckeen)
force-pushed
the
reportReasonMetric
branch
from
July 9, 2026 22:03
7d23723 to
589eb8c
Compare
Signed-off-by: Matthew McKeen <matthew.mckeen@fastly.com>
Signed-off-by: Matthew McKeen <matthew.mckeen@fastly.com>
Signed-off-by: Matthew McKeen <matthew.mckeen@fastly.com>
Signed-off-by: Matthew McKeen <matthew.mckeen@fastly.com>
Signed-off-by: Matthew McKeen <matthew.mckeen@fastly.com>
Matthew McKeen (mmckeen)
force-pushed
the
reportReasonMetric
branch
from
July 15, 2026 15:44
589eb8c to
d261916
Compare
Matthew McKeen (mmckeen)
changed the title
Matthew McKeen (mmckeen)
force-pushed
the
reportReasonMetric
branch
from
July 20, 2026 00:45
dc25974 to
d261916
Compare
Matthew McKeen (mmckeen)
changed the title
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When debugging high levels of reported packets and drop events, it's useful to see the reasons why they were reported in order to properly tune sampling and other tunables.
It is the same for entries in the conntrack table that are GCed, the state the connection was in when GCed helps to tune for missed metrics.
Add a
reasonlabel to the current metrics to keep track of this.Also adds visibility into conntrack bytes and connections missing a known direction (
is_reply), useful to validate conntrack accuracy.Related Issue
#1760
Checklist
git commit -S -s ...). See this documentation on signing commits.Screenshots (if applicable) or Testing Completed
Deployed in cluster, metrics show reasonable debugging into parsed packets.
Additional Notes
Along the way I found a bug where we never report the final packet during graceful TCP connection teardown, fix that as well.
Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.