Conversation
… control Metro config. Update test app.
…c detector and dup detector.
tido64
reviewed
Jul 9, 2021
tido64
approved these changes
Jul 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add @rnx-kit/config properties which control whether or not rnx-bundle will use the cyclic detector, the duplicate detector, and typescript validation (not currently wired up but coming in my next PR).
We want kit configuration to "program" dependencies like Metro, as it is less error-prone than having developers do it themselves. It also eliminates a lot of boilerplate code in each kit project.
While working on this, I noticed we don't have a CLI test suite. Tracked by #375.
I also noticed that @rnx-kit/third-party-notices had encoded the monorepo directory name in some of its snapshot data. I fixed that, as the directory name isn't fixed (it's chosen by each developer).
Test plan
Manual validation using @rnx-kit/test-app.