fix(react-native-host): Various build fixes#4143
Merged
Merged
Conversation
The inner block in -setBridge: redeclares strongSelf, shadowing the outer strongSelf captured for the RCTExecuteOnMainQueue scope. With -Wshadow on this is a -Werror. Rename the inner reference to innerStrongSelf so it no longer shadows the outer.
…_BRIDGELESS The protocol conformance on ReactNativeHost is already conditional (`<RCTContextContainerHandling>` when USE_BRIDGELESS=1, otherwise `<RCTCxxBridgeDelegate>`), but the `#import <React/RCTCxxBridgeDelegate.h>` above it is unconditional. Consumers that don't expose that header in their USE_BRIDGELESS=1 React-Core surface fail to compile. Gate the import the same way the conformance is gated so the header is only required when it is actually used.
…me: body The semicolon between the method declarator and the body of `-viewWithModuleName:initialProperties:` is flagged by `-Wsemicolon-before-method-body`. With `-Werror` on, this is a build failure under stricter xcconfigs.
Saadnajmi
changed the title
Saadnajmi
force-pushed
the
fix-wshadow-strongself-rename
branch
from
602e266 to
d77bba7
Compare
tido64
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three small build fixes for
@rnx-kit/react-native-hostcocoa source.Description
strongSelfto fix -Wshadow. The inner block in-setBridge:redeclaresstrongSelf, shadowing the outerstrongSelfcaptured for theRCTExecuteOnMainQueuescope. Rename the inner reference toinnerStrongSelfso it no longer shadows the outer.<React/RCTCxxBridgeDelegate.h>behind#if !USE_BRIDGELESS. The protocol conformance is already conditional (<RCTContextContainerHandling>when USE_BRIDGELESS=1, otherwise<RCTCxxBridgeDelegate>), but the import above it is unconditional. Consumers that don't exposeRCTCxxBridgeDelegate.hin their USE_BRIDGELESS=1 React-Core surface fail to compile. Gate the import the same way the conformance is gated.;before-viewWithModuleName:initialProperties:body. Flagged by-Wsemicolon-before-method-body; build failure under-Werror.Test plan
Tested internally where we use stricter xcconfigs.