Content Model Shadow Edit Step 1: Split editor#1693
Merged
Conversation
JiuqingSong
changed the title
JiuqingSong
requested review from
Andres-CT98,
BryanValverdeU,
flyingbee2012,
ianeli1 and
juliaroldi
April 3, 2023 04:57
Collaborator
Author
JiuqingSong
marked this pull request as ready for review
April 3, 2023 04:57
BryanValverdeU
approved these changes
Apr 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to allow
ContentModelEditorappend more info into editor core and override core api, in this change I split theEditorclass into two parts:EditorCoreobject, and accept a editorCoreCreator function to create editor coreEditorBase, provide creator of EditorCoreThis change is just code moving, no logic change