Content Model Shadow Edit Step 4: Finally support shadow edit with Content Model#1696
Merged
Conversation
Collaborator
Author
JiuqingSong
requested review from
Andres-CT98,
BryanValverdeU,
flyingbee2012,
ianeli1 and
juliaroldi
April 3, 2023 22:31
JiuqingSong
marked this pull request as ready for review
April 3, 2023 22:31
BryanValverdeU
approved these changes
Apr 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to support shadow edit with Content Model, we need to override the original core API
switchShadowEditand allow call other functions like create content model. So in this change I split some functions out of ContentModelEditor to be new core API:Then we create a new function
createContentModelEditorCorethat will invoke originalcreateEditorCorefunction and build editor core forContentModelEditor, including appending these new core APIs, override shadow edit API when reuse model is allowed.We also disable changing cached model during shadow edit to make sure the cached model is always the same one for the content before shadow edit.
Related test cases added.