Leverage Content Model to insert the Pasted content from clipboard by BryanValverdeU · Pull Request #1716 · microsoft/roosterjs

BryanValverdeU · 2023-04-13T17:42:16Z

In order to start using content model to insert clipboard content to the editor we need to do some refactor on some utilities:

Move the createPasteFragment logic from roosterjs-editor-core package to roosterjs-editor-dom, so we can also use the logic in roosterjs-content-model.
Add a new property to BeforePasteEvent to let other plugins modify the way we process elements in the paste fragment, this will be used later in another PR.
Create a new core api createPasteModel that will use the PasteFragment to create and return a content model document.
In the ContentModelEditor Class, override the paste function so, instead of using insertContent, use mergeModel function

Bugs that may be fixes by leveraging Content Model with this change:
#456
#1065
#1322 partially, only the paste part is fixed, copy needs to fixed in another PR.
#920

…rosoft/roosterjs into u/bvalverde/pocForPasteEvent

JiuqingSong · 2023-04-14T21:39:56Z

+ * @param context The context object to provide related information
+ */
+
+export type PasteElementProcessor<T extends Node> = (


What is the difference between this interface and ElementProcessor?

Only that the return type needs to be a boolean.

In that case, I prefer change the common processor type to force it return a boolean and change all exiting processors to return true. Although this will change more files, but it makes things consitent.

I think instead of that I will just pass in a domToModelOption to all the event so we can change the behavior as needed.

…u/bvalverde/pocForPasteEvent

JiuqingSong · 2023-04-24T23:12:43Z

-    }
-
-    if (safeInstanceOf(htmlContent, 'HTMLElement')) {
+    if (safeInstanceOf(htmlContent, 'Node')) {


This is nice, thanks!

…u/bvalverde/pocForPasteEvent

…rosoft/roosterjs into u/bvalverde/pocForPasteEvent

…u/bvalverde/pocForPasteEvent

* add tests for image edit * fix build * Move getPasteSource from Plugins to Dom (#1708) * init * try fix tests * Content Model minor fix: Change parameter type (#1720) * Content Model: Fix #1702 Hyperlinking a text doesnt trigger ChangeSource.CreateLink event (#1703) * Content Model: Fix #1702 * fix build * fix test * fix build * Fix #1713 (#1718) * Fix Uncaught TypeError: Cannot read properties of undefined (reading 'parentNode') (#1725) * Fix Unhandled exception * fix test * remove unneeded changes * Decouple logic from Table Cell Selection into smaller files. (#1722) * Refactor * Add comment * Allow Content Model API to remove image border (#1733) * Modify API to allow accepting null * New demo button * Testing * Content Model: Fix #1684 (#1730) * Content Model: Improve edit plugin (#1728) * Content Model fidelity 1: Support lineHeight in list (#1731) * [1/3] Enable Strict mode in TableCellSelection Utils + Plugin (#1735) Enable Strict mode in Table Cell Selection Utils and the Plugin class * Content Model fidelity improvement 2: Support size in divider (#1732) * Content Model fidelity 2: Support size in divider * fix test * Content Model: Improve default format state (#1743) * Content Model: Improve default format state * add a test case * Add check for empty selectors, and empty CSS rule insertion (#1744) * add check for empty selectors, and empty cssRule * fix test case * Content Model: Fix #1738 delete space issue (#1740) * Content Model: Fix #1738 delete space issue * enable edit plugin in demo site by default * Fix space issue * fix cache behavior * Make additionalTagReplacements allow `null` value type. (#1745) * Fix additionalTagReplacements type in HtmlSanitizerOptions.ts * Make compiler happy * [2/3] Enable Strict mode on KeyDown Handler (#1736) * Table cell selection strict mode 1 * enable strict mode on handleKeyDown * [3/3] Enable Strict mode in Mouse Down Handler + Add Strict mode files (#1737) * Table cell selection strict mode 1 * enable strict mode on handleKeyDown * enable strict mode on mousedown * merge conflicts * Change from undefined to null * Revert "Paste as image feature" - convertPastedContentFromExcel (#1749) * revert only convertPastedContentFromExcel.ts * Leverage Content Model to insert the Pasted content from clipboard (#1716) In order to start using content model to insert clipboard content to the editor we need to do some refactor on some utilities: Move the createPasteFragment logic from roosterjs-editor-core package to roosterjs-editor-dom, so we can also use the logic in roosterjs-content-model. Add a new property to BeforePasteEvent to let other plugins modify the way we process elements in the paste fragment, this will be used later in another PR. Create a new core api createPasteModel that will use the PasteFragment to create and return a content model document. In the ContentModelEditor Class, override the paste function so, instead of using insertContent, use mergeModel function Bugs that may be fixes by leveraging Content Model with this change: #456 #1065 #1322 partially, only the paste part is fixed, copy needs to fixed in another PR. #920 * Don't return focus to editor when blur on image (#1742) * Don't return focus to editor when blur on image * Comment * Content Model fidelity improvement 3: Block format (#1751) * Content Model fidelity improvement 3: Block format * improve * fix test * Add a experimental feature for paste with ContentModel #1758 * 8.46.0 --------- Co-authored-by: Júlia Roldi <juliaroldi@microsoft.com> Co-authored-by: Bryan Valverde U <bvalverde@microsoft.com> Co-authored-by: Julia Roldi <87443959+juliaroldi@users.noreply.github.com> Co-authored-by: Ian Elizondo <ianeli@microsoft.com> Co-authored-by: Andres-CT98 <107568016+Andres-CT98@users.noreply.github.com> Co-authored-by: Ruijun Gao <rckgao@gmail.com>

* add tests for image edit * fix build * Move getPasteSource from Plugins to Dom (#1708) * init * try fix tests * Content Model minor fix: Change parameter type (#1720) * Content Model: Fix #1702 Hyperlinking a text doesnt trigger ChangeSource.CreateLink event (#1703) * Content Model: Fix #1702 * fix build * fix test * fix build * Fix #1713 (#1718) * Fix Uncaught TypeError: Cannot read properties of undefined (reading 'parentNode') (#1725) * Fix Unhandled exception * fix test * remove unneeded changes * Decouple logic from Table Cell Selection into smaller files. (#1722) * Refactor * Add comment * Allow Content Model API to remove image border (#1733) * Modify API to allow accepting null * New demo button * Testing * Content Model: Fix #1684 (#1730) * Content Model: Improve edit plugin (#1728) * Content Model fidelity 1: Support lineHeight in list (#1731) * [1/3] Enable Strict mode in TableCellSelection Utils + Plugin (#1735) Enable Strict mode in Table Cell Selection Utils and the Plugin class * Content Model fidelity improvement 2: Support size in divider (#1732) * Content Model fidelity 2: Support size in divider * fix test * Content Model: Improve default format state (#1743) * Content Model: Improve default format state * add a test case * Add check for empty selectors, and empty CSS rule insertion (#1744) * add check for empty selectors, and empty cssRule * fix test case * Content Model: Fix #1738 delete space issue (#1740) * Content Model: Fix #1738 delete space issue * enable edit plugin in demo site by default * Fix space issue * fix cache behavior * Make additionalTagReplacements allow `null` value type. (#1745) * Fix additionalTagReplacements type in HtmlSanitizerOptions.ts * Make compiler happy * [2/3] Enable Strict mode on KeyDown Handler (#1736) * Table cell selection strict mode 1 * enable strict mode on handleKeyDown * [3/3] Enable Strict mode in Mouse Down Handler + Add Strict mode files (#1737) * Table cell selection strict mode 1 * enable strict mode on handleKeyDown * enable strict mode on mousedown * merge conflicts * Change from undefined to null * Revert "Paste as image feature" - convertPastedContentFromExcel (#1749) * revert only convertPastedContentFromExcel.ts * Leverage Content Model to insert the Pasted content from clipboard (#1716) In order to start using content model to insert clipboard content to the editor we need to do some refactor on some utilities: Move the createPasteFragment logic from roosterjs-editor-core package to roosterjs-editor-dom, so we can also use the logic in roosterjs-content-model. Add a new property to BeforePasteEvent to let other plugins modify the way we process elements in the paste fragment, this will be used later in another PR. Create a new core api createPasteModel that will use the PasteFragment to create and return a content model document. In the ContentModelEditor Class, override the paste function so, instead of using insertContent, use mergeModel function Bugs that may be fixes by leveraging Content Model with this change: * Don't return focus to editor when blur on image (#1742) * Don't return focus to editor when blur on image * Comment * Content Model fidelity improvement 3: Block format (#1751) * Content Model fidelity improvement 3: Block format * improve * fix test * Add a experimental feature for paste with ContentModel #1758 * 8.46.0 --------- Co-authored-by: Júlia Roldi <juliaroldi@microsoft.com> Co-authored-by: Bryan Valverde U <bvalverde@microsoft.com> Co-authored-by: Julia Roldi <87443959+juliaroldi@users.noreply.github.com> Co-authored-by: Ian Elizondo <ianeli@microsoft.com> Co-authored-by: Andres-CT98 <107568016+Andres-CT98@users.noreply.github.com> Co-authored-by: Ruijun Gao <rckgao@gmail.com>

BryanValverdeU added 2 commits April 13, 2023 11:40

init

395a727

Merge branch 'master' into u/bvalverde/pocForPasteEvent

edf7d5c

BryanValverdeU commented Apr 13, 2023

View reviewed changes

Comment thread packages/roosterjs-content-model/lib/editor/coreApi/createPasteFragment.ts Outdated

BryanValverdeU added 3 commits April 13, 2023 11:58

dependencies fix

0310236

fix tests

b6e4420

Merge branch 'master' into u/bvalverde/pocForPasteEvent

803bac4

BryanValverdeU requested review from Andres-CT98, JiuqingSong, flyingbee2012, ianeli1 and juliaroldi April 14, 2023 14:19

BryanValverdeU marked this pull request as ready for review April 14, 2023 14:20

BryanValverdeU marked this pull request as draft April 14, 2023 14:21

BryanValverdeU added 2 commits April 14, 2023 09:40

refactor

a2ad7ec

Merge branch 'u/bvalverde/pocForPasteEvent' of https://github.com/mic…

ec10d2f

…rosoft/roosterjs into u/bvalverde/pocForPasteEvent

BryanValverdeU marked this pull request as ready for review April 14, 2023 16:03

BryanValverdeU changed the title ~~Add additional props to BeforePasteEvent to handle ContentModel~~ Leverage Content Model to insert the Pasted content from clipboard Apr 14, 2023

JiuqingSong reviewed Apr 14, 2023

View reviewed changes

BryanValverdeU added 6 commits April 17, 2023 08:15

Remove unneeded check

aafbb4f

Merge branch 'master' of https://github.com/microsoft/roosterjs into …

2790174

…u/bvalverde/pocForPasteEvent

use formatWithContentModel

15a13e4

Rearrange core apis

fd5bce8

fix current unit tests

c5a1def

Support Document Fragment in domToContentModel

db38f17

BryanValverdeU marked this pull request as draft April 17, 2023 22:44

BryanValverdeU added 4 commits April 20, 2023 13:12

refactor

cbd77ba

Unit test

1792c1d

fix test

59680b9

Merge branch 'master' into u/bvalverde/pocForPasteEvent

cb0e07b

BryanValverdeU marked this pull request as ready for review April 21, 2023 17:00

JiuqingSong reviewed Apr 24, 2023

View reviewed changes

JiuqingSong approved these changes Apr 24, 2023

View reviewed changes

BryanValverdeU added 5 commits April 25, 2023 07:56

Merge branch 'master' of https://github.com/microsoft/roosterjs into …

4c4165a

…u/bvalverde/pocForPasteEvent

Merge branch 'master' into u/bvalverde/pocForPasteEvent

42479a0

add missing api to tests

2d5fc08

Merge branch 'u/bvalverde/pocForPasteEvent' of https://github.com/mic…

2367927

…rosoft/roosterjs into u/bvalverde/pocForPasteEvent

Merge branch 'master' of https://github.com/microsoft/roosterjs into …

1f34621

…u/bvalverde/pocForPasteEvent

BryanValverdeU merged commit fdd91ee into master Apr 25, 2023

BryanValverdeU deleted the u/bvalverde/pocForPasteEvent branch April 25, 2023 22:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Leverage Content Model to insert the Pasted content from clipboard#1716

Leverage Content Model to insert the Pasted content from clipboard#1716
BryanValverdeU merged 22 commits into
masterfrom
u/bvalverde/pocForPasteEvent

BryanValverdeU commented Apr 13, 2023 •

edited

Loading

Uh oh!

Uh oh!

JiuqingSong Apr 14, 2023

Uh oh!

BryanValverdeU Apr 17, 2023

Uh oh!

JiuqingSong Apr 17, 2023

Uh oh!

BryanValverdeU Apr 20, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JiuqingSong Apr 24, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

BryanValverdeU commented Apr 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

JiuqingSong Apr 14, 2023

Choose a reason for hiding this comment

Uh oh!

BryanValverdeU Apr 17, 2023

Choose a reason for hiding this comment

Uh oh!

JiuqingSong Apr 17, 2023

Choose a reason for hiding this comment

Uh oh!

BryanValverdeU Apr 20, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JiuqingSong Apr 24, 2023

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

BryanValverdeU commented Apr 13, 2023 •

edited

Loading