Content Model: Fix editing with default format issue#1773
Merged
Conversation
JiuqingSong
requested review from
Andres-CT98,
BryanValverdeU,
flyingbee2012,
ianeli1 and
juliaroldi
May 3, 2023 04:45
JiuqingSong
marked this pull request as draft
May 3, 2023 20:41
JiuqingSong
marked this pull request as ready for review
May 3, 2023 21:40
BryanValverdeU
approved these changes
May 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes fix several issue related to default format and content model editing.
PickerPlugin, we will let browser/other plugins (for Content Model,ContentModelEditPlugin) to delete the element, to avoid leaving an empty DIV/SPAN that cannot hold focus.deleteSelectionsso that outer function will prevent default behavior of delete, to avoid delete last DIV/SPAN and cause an empty editorContentModelFormatPluginwill apply this default format to current segmentapplyPendingFormatwill convert current implicit paragraph to non-implicit, so that it will render DIV element to let it hold focus. This can fix the problem when type directly before/after a table, then a new paragraph will be created.Related bugs:
#203168 font changes after I delete an @name
#195796 When writing 2 lines below a loop component, the font style of text change