Skip to content

Fix TypeError: Cannot read properties of null (reading 'getInlineElementBefore')#1789

Merged
BryanValverdeU merged 2 commits into
masterfrom
u/bvalverde/fixPickerBug
May 11, 2023
Merged

Fix TypeError: Cannot read properties of null (reading 'getInlineElementBefore')#1789
BryanValverdeU merged 2 commits into
masterfrom
u/bvalverde/fixPickerBug

Conversation

@BryanValverdeU

@BryanValverdeU BryanValverdeU commented May 10, 2023

Copy link
Copy Markdown
Contributor

Fix an error in Picker Plugin by adding some null checks:

TypeError: Cannot read properties of null (reading 'getInlineElementBefore')

roosterjs-editor-plugins/lib/plugins/Picker/PickerPlugin.ts getInlineElementBefore 483 
roosterjs-editor-plugins/lib/plugins/Picker/PickerPlugin.ts tryRemoveNode 443 
roosterjs-editor-plugins/lib/plugins/Picker/PickerPlugin.ts onKeyDownEvent 192

@BryanValverdeU
BryanValverdeU merged commit 188679b into master May 11, 2023
@BryanValverdeU
BryanValverdeU deleted the u/bvalverde/fixPickerBug branch May 11, 2023 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JiuqingSong JiuqingSong JiuqingSong approved these changes
@flyingbee2012 flyingbee2012 Awaiting requested review from flyingbee2012
@ianeli1 ianeli1 Awaiting requested review from ianeli1
@juliaroldi juliaroldi Awaiting requested review from juliaroldi
@Andres-CT98 Andres-CT98 Awaiting requested review from Andres-CT98

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@BryanValverdeU @JiuqingSong