Content Model: Move default format back to DIV#1819
Merged
Conversation
JiuqingSong
changed the title
JiuqingSong
marked this pull request as ready for review
May 23, 2023 18:44
JiuqingSong
requested review from
Andres-CT98,
BryanValverdeU,
flyingbee2012,
ianeli1 and
juliaroldi
May 23, 2023 18:44
JiuqingSong
changed the title
BryanValverdeU
approved these changes
May 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have found some issues that can cause format lost during editing. One of the reason is with ExperimentalFeature
DefaultFormatInSpan, we always apply default format to a inner SPAN instead of the DIV. So during some editing operation, or some legacy roosterjs API, it can cause the content is located outside of the format SPAN.In that change I revert this feature as well as another experimental feature
DefaultFormatOnContainerto not apply default format to editor DIV since it can hide this problem.For container model, we will also apply default format to paragraph when write back, and no need to write the same format inside SPAN if it is not changed.
Before change:
After change:
