Support context menu in ImageSelection Plugin#1831
Merged
Conversation
juliaroldi
requested review from
Andres-CT98,
BryanValverdeU,
JiuqingSong,
flyingbee2012 and
ianeli1
May 25, 2023 20:17
JiuqingSong
reviewed
May 25, 2023
| if ( | ||
| safeInstanceOf(contextMenuTarget, 'HTMLImageElement') && | ||
| (actualSelection.type !== SelectionRangeTypes.ImageSelection || | ||
| (actualSelection.type === SelectionRangeTypes.ImageSelection && |
Collaborator
There was a problem hiding this comment.
You can remove the check to actualSelection.type === SelectionRangeTypes.ImageSelection because when it goes here, this must be true
JiuqingSong
approved these changes
May 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of select the image when right click, use Context Menu event to select the image when right click a image.
Add copy/cut options to the image context menu to test image selection.
Before:
After:
