Always disable cache element on paste#1836
Merged
Merged
Conversation
BryanValverdeU
requested review from
Andres-CT98,
JiuqingSong,
flyingbee2012,
ianeli1 and
juliaroldi
May 26, 2023 16:07
JiuqingSong
approved these changes
May 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to disable the caching of elements on paste, otherwise in some scenarios, for example for table cells, we do not apply the correct format if the editor is in dark mode.
This PR adds the disableCacheElements to the domToContentModel when invoking createPasteModel