Complete shadow reporter parity coverage - #5992
Open
Sean Larkin (TheLarkInn) wants to merge 1 commit into
Open
Conversation
Sean Larkin (TheLarkInn)
requested a review
from Bharat Middha (bmiddha)
as a code owner
August 28, 2026 04:30
This was referenced Aug 28, 2026
Sean Larkin (TheLarkInn)
force-pushed
the
copilot/reporter-r3c-shadow-parity
branch
from
August 28, 2026 06:07
adec9ae to
22089a0
Compare
This was referenced Aug 28, 2026
Member
Author
|
Combined deep review of current head No critical, high, or medium actionable findings. No useful low follow-ons. |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: d6318e80-5da9-4858-a147-817e8692f10e
Sean Larkin (TheLarkInn)
force-pushed
the
copilot/reporter-r3c-shadow-parity
branch
from
August 28, 2026 17:13
22089a0 to
7a751fc
Compare
Member
Author
|
Restacked onto exact #5991 head |
Member
Author
|
Final combined review of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #5976
Stack
Complete merge order: #5985 -> #5986 -> #5987 -> #5989 -> #5988 -> #5991 -> #5992.
R6 #5993 is a parallel fork from #5989 and is not part of this child chain.
Summary
StreamCollatorrendering remain byte-identical while shadow reporting emits no raw outputIndependent stack review
Validation
rush test --only @rushstack/rush-reporter --only @microsoft/rush-lib --only @microsoft/rush --only @rushstack/rush-sdk(8 operations passed)rush build --to @microsoft/rush --to @rushstack/rush-sdk(52 operations passed)rush checkrush change --verify --no-fetchNo-output guarantee
No sink is created unless explicitly supplied. The shadow operation adapter emits lifecycle/status/diagnostic events only, never
externalOutput; focused tests compare stdout, stderr, and the complete legacyStreamCollatorrendering byte-for-byte with and without shadow reporting.Non-goals
StreamCollatorreplacement or R5 raw operation/output routing