fixing 32bit truncation for HKDF and sp800 - #101
Merged
Khang (nnmkhang) merged 1 commit intoMay 22, 2026
Conversation
Member
|
lgtm |
Khang (nnmkhang)
marked this pull request as ready for review
May 21, 2026 23:27
Mitch Lindgren (mlindgren)
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes:
Changed sp800 and hdkf API to output
usizerather thanu64to not truncate on 32 bit systemBreaking Changes if any:
HKDF API signature changed:
Same applies for Sp800 but the change is not in cargo yet.
✅ Admin Checklist
cargo test --all-featuresonWindowsandWSL.Check the Developer Guidelines in DEVELOPER.md for more info.