Addressing Max's comments - #120
Merged
Khang (nnmkhang) merged 1 commit intoSep 3, 2026
Merged
Conversation
Khang (nnmkhang)
marked this pull request as ready for review
September 2, 2026 15:21
MS-megliu
approved these changes
Sep 3, 2026
Collaborator
There was a problem hiding this comment.
One maintenance note (non-blocking): packages-microsoft-prod.deb is a rolling artifact rather than a versioned release, so CI will hard-fail with a checksum mismatch whenever Microsoft refreshes it. That is the right fail-closed trade-off — just worth knowing it will need a manual bump when it happens.
Khang (nnmkhang)
deleted the
user/khangnguyen/release-0.6-max-review-arm-ci
branch
September 3, 2026 18:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes:
Addressing Max's comments
Breaking Changes if any:
N/A
✅ Admin Checklist
cargo test --all-featuresonWindowsandWSL.Check the Developer Guidelines in DEVELOPER.md for more info.