Skip to content

Implement std::error::Error for SymCryptError - #95

Merged
Steven Malis (smalis-msft) merged 1 commit into
microsoft:release/0.6.0from
smalis-msft:error-error
Apr 24, 2026
Merged

Implement std::error::Error for SymCryptError#95
Steven Malis (smalis-msft) merged 1 commit into
microsoft:release/0.6.0from
smalis-msft:error-error

Conversation

@smalis-msft

Copy link
Copy Markdown
Collaborator

Implement std::error::Error for SymCryptError. As SymCryptError already defines Display, this is a very easy and small addition.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nnmkhang

Khang (nnmkhang) commented Apr 23, 2026

Copy link
Copy Markdown
Contributor

LGTM, are you able to change target branch to release/0.6.0?

@nnmkhang
Khang (nnmkhang) requested review from Khang (nnmkhang) and removed request for Khang (nnmkhang) April 23, 2026 21:15
@smalis-msft
Steven Malis (smalis-msft) changed the base branch from main to release/0.6.0 April 24, 2026 15:04
@smalis-msft

Copy link
Copy Markdown
Collaborator Author

Done!

Co-authored-by: Copilot <copilot@github.com>

@nnmkhang Khang (nnmkhang) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smalis-msft
Steven Malis (smalis-msft) merged commit c5cbfeb into microsoft:release/0.6.0 Apr 24, 2026
12 checks passed
@smalis-msft
Steven Malis (smalis-msft) deleted the error-error branch April 24, 2026 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants