Remove a few unnecessary internal setters#611
Merged
dluc merged 1 commit intomicrosoft:mainfrom Apr 25, 2023
Merged
Conversation
github-actions
bot
added
.NET
lemillermicrosoft
approved these changes
Apr 24, 2023
lemillermicrosoft
added
the
PR: ready to merge
dluc
approved these changes
Apr 25, 2023
dluc
pushed a commit
that referenced
this pull request
Apr 29, 2023
### Motivation and Context Minor cleanup. ### Description These are unnecessary. As I was reviewing through the code I happened to notice they were unused or had greater than required visibility. Also removed a few unnecessary `public` visibility annotations from an interface (they were nops and were inconsistent with the rest of the interface), as well as a few initializers that were initializing to the default value and thus were duplicative.
dehoward
pushed a commit
to lemillermicrosoft/semantic-kernel
that referenced
this pull request
Jun 1, 2023
### Motivation and Context Minor cleanup. ### Description These are unnecessary. As I was reviewing through the code I happened to notice they were unused or had greater than required visibility. Also removed a few unnecessary `public` visibility annotations from an interface (they were nops and were inconsistent with the rest of the interface), as well as a few initializers that were initializing to the default value and thus were duplicative.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Minor cleanup.
Description
These are unnecessary. As I was reviewing through the code I happened to notice they were unused or had greater than required visibility. Also removed a few unnecessary
publicvisibility annotations from an interface (they were nops and were inconsistent with the rest of the interface), as well as a few initializers that were initializing to the default value and thus were duplicative.Contribution Checklist
dotnet format