Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -34,12 +34,12 @@ public interface ISKFunction
/// IMPORTANT: native functions might use semantic functions internally,
/// so when this property is False, executing the function might still involve AI calls.
/// </summary>
public bool IsSemantic { get; }
bool IsSemantic { get; }

/// <summary>
/// AI service settings
/// </summary>
public CompleteRequestSettings RequestSettings { get; }
CompleteRequestSettings RequestSettings { get; }

/// <summary>
/// Returns a description of the function, including parameters.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ public SKContext Fail(string errorDescription, Exception? exception = null)
/// <summary>
/// Semantic memory
/// </summary>
public ISemanticTextMemory Memory { get; internal set; }
public ISemanticTextMemory Memory { get; }

/// <summary>
/// Read only skills collection
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -64,12 +64,12 @@ public EmbeddingReadOnlySpan(EmbeddingSpan<TEmbedding> span, bool isNormalized =
/// <summary>
/// Gets the underlying <see cref="ReadOnlySpan{T}"/> of unmanaged data.
/// </summary>
public ReadOnlySpan<TEmbedding> ReadOnlySpan { get; internal set; }
public ReadOnlySpan<TEmbedding> ReadOnlySpan { get; }

/// <summary>
/// True if the data was specified to be normalized at construction.
/// </summary>
public bool IsNormalized { get; internal set; }
public bool IsNormalized { get; }

/// <summary>
/// Calculates the dot product of this vector with another.
Expand Down
2 changes: 1 addition & 1 deletion dotnet/src/SemanticKernel/AI/Embeddings/EmbeddingSpan.cs
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ public EmbeddingSpan(TEmbedding[] vector)
/// <summary>
/// Gets the underlying <see cref="Span{T}"/> of unmanaged data.
/// </summary>
public Span<TEmbedding> Span { get; internal set; }
public Span<TEmbedding> Span { get; }

/// <summary>
/// Normalizes the underlying vector in-place, such that the Euclidean length is 1.
Expand Down
6 changes: 3 additions & 3 deletions dotnet/src/SemanticKernel/Orchestration/Plan.cs
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ public sealed class Plan : ISKFunction
/// Gets the next step index.
/// </summary>
[JsonPropertyName("next_step_index")]
public int NextStepIndex { get; internal set; } = 0;
public int NextStepIndex { get; private set; }

#region ISKFunction implementation

Expand All @@ -77,11 +77,11 @@ public sealed class Plan : ISKFunction

/// <inheritdoc/>
[JsonIgnore]
public bool IsSemantic { get; internal set; } = false;
public bool IsSemantic { get; private set; }

/// <inheritdoc/>
[JsonIgnore]
public CompleteRequestSettings RequestSettings { get; internal set; } = new();
public CompleteRequestSettings RequestSettings { get; private set; } = new();

#endregion ISKFunction implementation

Expand Down