Skip to content

Suppress successful source status notes #1036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
paullizer merged 1 commit into from
Jul 15, 2026
Merged

Suppress successful source status notes #1036

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion application/single_app/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@
EXECUTOR_TYPE = 'thread'
EXECUTOR_MAX_WORKERS = 30
SESSION_TYPE = 'filesystem'
VERSION = "0.250.064"
VERSION = "0.250.065"

SESSION_COOKIE_SAMESITE = os.getenv('SESSION_COOKIE_SAMESITE', 'Lax')
SESSION_COOKIE_HTTPONLY = os.getenv('SESSION_COOKIE_HTTPONLY', 'true').lower() != 'false'
Expand Down
3 changes: 2 additions & 1 deletion application/single_app/functions_chat_orchestration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -464,7 +464,8 @@ def build_turn_orchestration_guidance_message(plan):
f'Required source attempts for this turn: {source_labels or "none"}.',
f'Evidence requirements inferred from the request: {requirement_labels or "none beyond selected sources"}.',
'Use the results from every attempted source when producing the final response.',
'Do not silently ignore a selected source. If a source was skipped, unavailable, unauthorized, failed, or returned no evidence, state that clearly.',
'Do not add a source-status note or list sources merely to report successful attempts.',
'Only mention source execution status when a required source was skipped, unavailable, unauthorized, failed, returned no evidence, or produced partial results.',
'Use only supported facts, preserve material source conflicts, and identify partial results instead of filling evidence gaps with assumptions.',
]

Expand Down
9 changes: 7 additions & 2 deletions functional_tests/test_chat_turn_orchestration_plan.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# test_chat_turn_orchestration_plan.py
"""
Functional test for the chat turn orchestration planning foundation.
Version: 0.250.064
Version: 0.250.065
Implemented in: 0.250.058

This test ensures every turn receives a direct or coordinated plan, selected
Expand Down Expand Up @@ -125,6 +125,11 @@ def test_selected_capabilities_are_required_attempts():
}
assert 'must not be persisted' not in json.dumps(plan)

guidance = build_turn_orchestration_guidance_message(plan)
assert 'Do not add a source-status note or list sources merely to report successful attempts.' in guidance
assert 'Only mention source execution status when a required source was skipped' in guidance
assert 'or produced partial results.' in guidance


def test_grounded_image_is_a_coordinated_task_profile():
plan = build_turn_orchestration_plan(
Expand Down Expand Up @@ -351,7 +356,7 @@ def test_streaming_chat_path_persists_and_applies_plan():
route_source = ROUTE_BACKEND_CHATS.read_text(encoding='utf-8')
config_source = CONFIG_FILE.read_text(encoding='utf-8')

assert 'VERSION = "0.250.064"' in config_source
assert 'VERSION = "0.250.065"' in config_source
assert 'turn_orchestration_plan = build_turn_orchestration_plan(' in route_source
assert 'requested_action_document_ids = _normalize_conversation_task_document_ids(' in route_source
assert 'requested_action_document_ids\n if requested_action_document_ids' in route_source
Expand Down