Issue 37 data driven placement - #44
Merged
adilei merged 2 commits intoAug 6, 2026
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: e4d624ee-fa8f-49d2-8b39-0ec71fc31e84
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: e4d624ee-fa8f-49d2-8b39-0ec71fc31e84
adilei
approved these changes
Aug 6, 2026
adilei
left a comment
adilei
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed the data-driven placement refactor. Nicely replaces the hardcoded architecture === "scout" branching with manifest-driven placements + installTargetLabel, and the guardrails are solid — manifest validation, requireTargetPlacement enforcement in the builder, and the catalogue-coverage check for enabled targets. Built the branch locally and the full test suite passes. Confirmed that adding a new export-only target is essentially pure config. LGTM 👍
adilei
added a commit
that referenced
this pull request
Aug 6, 2026
Add an export-only "Agent skill" build target for any skill-capable agent: a data-driven architecture with no host-specific tools, enabled by the placement refactor in #44. - Manifest: new agent-skill architecture placed before copilot-studio; single export-only skill target; label "Agent skill", responsibility-aware tile note. - New static, versioned catalogue (2026-08-06) listing only portable capabilities (files, shell/CLIs, HTTP APIs) — no proprietary/native tools. Auto-registered via import.meta.glob. - Registry + catalogue-registry test updates, including a deterministic SHA-256 lock (27cb863e…). Validation: typecheck, tests (76 passing), and build ("Catalogue bundle boundary verified.") all green. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes skill placement data-driven by moving install/export capabilities into the architecture registry and deriving the UI from that metadata. It preserves the current Scout and Cowork behavior, validates unsupported placements in the main process, and makes future targets easier to add without renderer changes. The change is covered by regression tests and was manually smoke tested in the UI. Closes #37.