Skip to content

skill-creator: lifecycle guidance and Azure SDK patterns reference#379

Merged
LarryOsterman merged 12 commits into
mainfrom
larryo/split/skill-creator-lifecycle
Jul 16, 2026
Merged

skill-creator: lifecycle guidance and Azure SDK patterns reference#379
LarryOsterman merged 12 commits into
mainfrom
larryo/split/skill-creator-lifecycle

Conversation

@LarryOsterman

Copy link
Copy Markdown
Member

Split from #375 (1 of 5).

Adds skill lifecycle guidance to skill-creator and a new Azure SDK patterns reference.

Files:

  • .github/skills/skill-creator/SKILL.md
  • .github/skills/skill-creator/references/azure-sdk-patterns.md

Split from #375: updates skill-creator SKILL.md with skill lifecycle
guidance and adds references/azure-sdk-patterns.md.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 9429ad33-6f31-4ec5-ba00-0f11b5afb82e
@LarryOsterman
LarryOsterman requested a review from thegovind as a code owner July 15, 2026 17:21
Copilot AI review requested due to automatic review settings July 15, 2026 17:21
@LarryOsterman
LarryOsterman requested a review from a team July 15, 2026 17:22

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Expands Azure SDK skill authoring guidance with lifecycle, token-budget, validation, and reference-organization patterns.

Changes:

  • Adds workflow and reference-extraction guidance.
  • Introduces efficiency and regeneration validation gates.
  • Documents the Azure SDK reference-directory structure.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 10 comments.

File Description
.github/skills/skill-creator/SKILL.md Adds lifecycle, authoring, validation, and regeneration guidance.
.github/skills/skill-creator/references/azure-sdk-patterns.md Adds reference-directory and sync/async guidance.

Comment thread .github/skills/skill-creator/SKILL.md Outdated
Comment thread .github/skills/skill-creator/SKILL.md Outdated
Comment thread .github/skills/skill-creator/SKILL.md Outdated
Comment thread .github/skills/skill-creator/SKILL.md Outdated
Comment thread .github/skills/skill-creator/SKILL.md Outdated
Comment thread .github/skills/skill-creator/SKILL.md Outdated
Comment thread .github/skills/skill-creator/SKILL.md Outdated
Comment thread .github/skills/skill-creator/SKILL.md
Comment thread .github/skills/skill-creator/SKILL.md Outdated
Comment thread .github/skills/skill-creator/references/azure-sdk-patterns.md Outdated
@LarryOsterman

Copy link
Copy Markdown
Member Author

Split from #375 (see #375 for the full split plan). Do not merge #375 until this and the sibling split PRs (#379, #380, #381, #382, #383) are merged.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings July 15, 2026 21:54
Azure SDK guidance should not express a preference for either sync or
async clients. Updated SKILL.md and azure-sdk-patterns.md to present
both forms as first-class options with equal priority, removing the
"pick one mode" directives while retaining the rule against mixing
sync and async within a single call path.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.

Comment thread .github/skills/skill-creator/SKILL.md Outdated
Comment thread .github/skills/skill-creator/SKILL.md Outdated
Comment thread .github/skills/skill-creator/SKILL.md Outdated
Comment thread .github/skills/skill-creator/SKILL.md Outdated
Comment thread .github/skills/skill-creator/SKILL.md Outdated
Copilot AI review requested due to automatic review settings July 15, 2026 21:58
The previous benchmark table referenced azure-ai-ml-py and other Python
skills with descriptions that didn't match their actual content (e.g.,
azure-ai-ml-py covers workspaces/data/models/compute/jobs/pipelines, not
a single train+register workflow). Replace with verified Rust skills from
this repository that actually demonstrate the one-workflow/1-2-example
criteria. Also drop the misleading 'Tokens Δ' column which implied
historical optimization comparisons not applicable to new skills.
@LarryOsterman

Copy link
Copy Markdown
Member Author

@copilot Fix the outstanding review comments.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 8 comments.

Comment thread .github/skills/skill-creator/SKILL.md Outdated
Comment thread .github/skills/skill-creator/SKILL.md Outdated
Comment thread .github/skills/skill-creator/SKILL.md Outdated
Comment thread .github/skills/skill-creator/SKILL.md Outdated
Comment thread .github/skills/skill-creator/SKILL.md Outdated
Comment thread .github/skills/skill-creator/SKILL.md Outdated
Comment thread .github/skills/skill-creator/SKILL.md Outdated
Comment thread .github/skills/skill-creator/SKILL.md Outdated
Copilot AI review requested due to automatic review settings July 15, 2026 22:02

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 9 comments.

Comment thread .github/skills/skill-creator/SKILL.md Outdated
Comment thread .github/skills/skill-creator/SKILL.md Outdated
Comment thread .github/skills/skill-creator/SKILL.md Outdated
Comment thread .github/skills/skill-creator/SKILL.md Outdated
Comment thread .github/skills/skill-creator/SKILL.md Outdated
Comment thread .github/skills/skill-creator/SKILL.md Outdated
Comment thread .github/skills/skill-creator/SKILL.md Outdated
Comment thread .github/skills/skill-creator/SKILL.md Outdated
Comment thread .github/skills/skill-creator/SKILL.md Outdated
Copilot AI review requested due to automatic review settings July 15, 2026 23:29
@LarryOsterman
LarryOsterman removed the request for review from Copilot July 15, 2026 23:29

Copilot AI commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

@copilot the test CI pipeline is failing currently, please fix it.

Fixed in commit ce987ef.

I investigated the failing Smoke Test run and logs, and the failure was caused by an invalid tests/pnpm-workspace.yaml (packages field missing or empty). I replaced the placeholder file with a valid workspace config (packages: ['.']) and added onlyBuiltDependencies: [esbuild].

Validated locally with the CI-equivalent commands (npx pnpm@9 install, npx pnpm@9 typecheck, npx pnpm@9 test:run).

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

Comment on lines +622 to 624
> 1. **Prefer `DefaultAzureCredential` for local development.** It works as-is with Azure CLI / VS Code / Developer CLI. For production, either constrain `DefaultAzureCredential` to production-safe credentials or use a specific credential directly. Avoid connection strings, account/API keys — they bypass Entra audit and rotation.
> - Local dev: `DefaultAzureCredential` works as-is.
> - Production: set `AZURE_TOKEN_CREDENTIALS=prod` (or `AZURE_TOKEN_CREDENTIALS=<specific_credential>`) to constrain the credential chain to production-safe credentials.
Comment on lines +120 to +122
- Exceeding max limit → refactor into `/references/` subdirectories
- When approaching 500 lines → move entire sections to reference files
- Annotate with `<!-- Token Count: ~XXXX (target: 1100, max: 1500) -->` immediately below the skill's H1
Comment thread tests/pnpm-workspace.yaml Outdated
Comment on lines +1 to +5
packages:
- .

onlyBuiltDependencies:
- esbuild

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.

Comment thread .github/skills/skill-creator/SKILL.md
Comment thread .github/skills/skill-creator/SKILL.md
Comment thread .github/skills/skill-creator/SKILL.md
Comment thread tests/pnpm-workspace.yaml Outdated
Comment thread .github/skills/skill-creator/SKILL.md Outdated
Comment thread .github/skills/skill-creator/SKILL.md Outdated
Copilot AI review requested due to automatic review settings July 16, 2026 21:41
@LarryOsterman
LarryOsterman removed the request for review from Copilot July 16, 2026 21:41
@LarryOsterman
LarryOsterman requested a review from Copilot July 16, 2026 21:52

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

Comment thread tests/pnpm-workspace.yaml Outdated
Comment thread .github/skills/skill-creator/SKILL.md Outdated
Comment thread .github/skills/skill-creator/SKILL.md Outdated
Comment thread .github/skills/skill-creator/SKILL.md Outdated
Comment thread .github/skills/skill-creator/SKILL.md Outdated
Copilot AI review requested due to automatic review settings July 16, 2026 22:02
@LarryOsterman
LarryOsterman removed the request for review from Copilot July 16, 2026 22:02
@LarryOsterman
LarryOsterman merged commit 752edb9 into main Jul 16, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants