Fix Azure Windows pipeline and CLI test failures#2920
Merged
Conversation
Port the Azure pipeline nbgv install fix from microsoft/teams.ts#650 so the publish pipeline authenticates to Azure Artifacts and installs nbgv from the TeamsSDKPreviews NuGet feed. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9bf4ae44-65a7-4cd5-8cbc-c1f1e561160f
Contributor
There was a problem hiding this comment.
Pull request overview
Ports an Azure Pipelines fix to ensure nbgv can be installed in the publish pipeline by authenticating to Azure Artifacts and using a temporary NuGet config pointing at the TeamsSDKPreviews feed.
Changes:
- Adds
NuGetAuthenticate@1prior to installingnbgv. - Writes a temporary NuGet config targeting the TeamsSDKPreviews Azure Artifacts feed and uses it for
dotnet tool install -g nbgv. - Ensures the global .NET tools path is prepended before invoking
nbgv cloud.
Show a summary per file
| File | Description |
|---|---|
| .azdo/publish.yml | Adds Azure Artifacts auth + temp NuGet config to make nbgv install reliable in the Windows 1ES pipeline. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Low
corinagum
approved these changes
Jul 17, 2026
Replace the Unix-only rm invocation in the CLI build script with a Node fs.rmSync clean step so Azure Windows agents can build the package. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9bf4ae44-65a7-4cd5-8cbc-c1f1e561160f
heyitsaamir
changed the title
heyitsaamir
enabled auto-merge (squash)
July 17, 2026 22:23
Use POSIX separators for generated app-create command hints so Windows test and CLI output keep stable slash formatting while preserving platform-native filesystem paths for credential writes. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9bf4ae44-65a7-4cd5-8cbc-c1f1e561160f
heyitsaamir
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rm -rf distwith a Nodefs.rmSyncclean step for Azure Windows agents.teams app create --env ...command hints to use stable POSIX separators while keeping actual credential file paths platform-native.Validation
npm -w @microsoft/teams.cli test -- project-new-bot-provision.test.tsnpx turbo build --filter=@microsoft/teams.clinpm -w @microsoft/teams.cli testgit diff --check -- packages/cli/src/commands/project/shared.ts packages/cli/package.json .azdo/publish.ymlruby -e 'require "yaml"; YAML.load_file(".azdo/publish.yml"); puts "yaml ok"'rg "NuGetAuthenticate|NuGet.TeamsSDKPreviews.config|dotnet tool install -g nbgv --configfile|TeamsSDKPreviews/nuget" .azdo/publish.yml