Temporary: skip streaming tests #200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the entire test file test_http_stream.py, eliminating all unit test coverage for the HttpStream class. The file contained 188 lines of test code covering critical streaming functionality including timeout handling, retry logic, typing activities, and message sequencing.
Comments suppressed due to low confidence (1)
packages/apps/tests/test_http_stream.py:1
- Removing this entire test file eliminates critical test coverage for the
HttpStreamclass. The deleted tests cover essential functionality including: 500ms timeout flush behavior, timer restart on multiple emits, timeout error handling with retries, typing activity sending viaupdate(), and message sequencing. TheHttpStreamclass is a production component used byHttpPlugin.create_stream()and implements complex async behavior with timeout management, retry logic, and state tracking. Without these tests, regressions in streaming functionality could go undetected. Consider restoring these tests or providing equivalent coverage elsewhere.
heyitsaamir
reviewed
Nov 3, 2025
Collaborator
heyitsaamir
left a comment
heyitsaamir
left a comment
There was a problem hiding this comment.
https://doc.pytest.org/en/latest/how-to/skipping.html#skip-all-test-functions-of-a-class-or-module YOu don't need to delete the file. Just skip it for now.
MehakBindra
force-pushed
the
mehak/streamingtests
branch
from
ec1393a to
51d55d4
Compare
MehakBindra
changed the title
heyitsaamir
approved these changes
Nov 3, 2025
Merged
heyitsaamir
added a commit
that referenced
this pull request
Nov 10, 2025
- Remove support for 3.14 (#207) - Add Federated Identity Credentials support (#203) - Add User Managed Identity support via MSAL (#192) - Introduce msal (#191) - Populate empty package READMEs with usage examples (#196) - Rename Teams AI to Teams SDK 🎉 (#201) - HTTPPlugin : Add a builder option to provide custom server (enables providing options like ssl etc) (#185) - get type hint of class, not object (#202) - Temporary: skip streaming tests (#200) - Fix workflow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporarily removing streaming tests while we rewrite to make them spontaneous (remove all real time delays )