get type hint of class, not object #202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the usage of get_type_hints() in the plugin injection system by passing the plugin class instead of the plugin instance.
Key Changes
- Fixed
get_type_hints()call to useplugin.__class__instead ofplugindirectly, aligning with the proper typing module API usage
lilyydu
approved these changes
Nov 4, 2025
Collaborator
lilyydu
left a comment
lilyydu
left a comment
There was a problem hiding this comment.
Thanks for adding this!
Merged
heyitsaamir
added a commit
that referenced
this pull request
Nov 10, 2025
- Remove support for 3.14 (#207) - Add Federated Identity Credentials support (#203) - Add User Managed Identity support via MSAL (#192) - Introduce msal (#191) - Populate empty package READMEs with usage examples (#196) - Rename Teams AI to Teams SDK 🎉 (#201) - HTTPPlugin : Add a builder option to provide custom server (enables providing options like ssl etc) (#185) - get type hint of class, not object (#202) - Temporary: skip streaming tests (#200) - Fix workflow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise it stops working with python 3.14