fix: align integration test env var names with C# convention - #511
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Aligns Python integration test configuration to use the same environment variable names as the C# reference implementation, reducing cross-SDK friction when sharing .env files and CI variables.
Changes:
- Renamed required integration-test env var lookups to
TEST_SERVICEURL,TEST_CONVERSATIONID,TEST_TEAMID, andTEST_CHANNELID. - Made
meeting_idoptional and switched its env var lookup toTEST_MEETINGID.
Change TEST_SERVICE_URL → TEST_SERVICEURL, TEST_CONVERSATION_ID → TEST_CONVERSATIONID, TEST_TEAM_ID → TEST_TEAMID, TEST_CHANNEL_ID → TEST_CHANNELID, TEST_MEETING_ID → TEST_MEETINGID (now optional). Auth vars (AZURE_TENANT_ID, etc.) remain PY-specific since C# uses ASP.NET AzureAd__* config binding convention. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: d5105671-e3e2-48b0-8ce3-a36f6c43eefd
Corina (corinagum)
force-pushed
the
cg/fix-env-vars
branch
from
July 22, 2026 18:18
c08453a to
9884257
Compare
Mehak Bindra (MehakBindra)
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aligns PY integration test environment variable names with the C# reference implementation (Rido's original):
TEST_SERVICE_URL→TEST_SERVICEURLTEST_CONVERSATION_ID→TEST_CONVERSATIONIDTEST_TEAM_ID→TEST_TEAMIDTEST_CHANNEL_ID→TEST_CHANNELIDTEST_MEETING_ID→TEST_MEETINGID(now optional)This ensures all three SDKs (C#, TS, PY) use the same env var names for integration tests, simplifying shared .env files and CI configuration.
10 passed, 2 skipped ✅