Skip to content

Disable PGO for nightly builds #17749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
DHowett merged 1 commit into from
Aug 20, 2024
Merged

Disable PGO for nightly builds #17749

DHowett merged 1 commit into from
Aug 20, 2024

Conversation

@DHowett
Copy link
Member

@DHowett DHowett commented Aug 20, 2024 •
edited
Loading

Refs #17699

@DHowett DHowett requested review from lhecker and zadjii-msft August 20, 2024 16:22
@zadjii-msft
Copy link
Member

zadjii-msft commented Aug 20, 2024

So, to be clear, this is a test to see if disabling PGO for this nightly build fixes #17699, right? We definitely can't ship with PGO disabled, but this should let us narrow the issue down?

@lhecker
Copy link
Member

lhecker commented Aug 20, 2024

We definitely can't ship with PGO disabled, but this should let us narrow the issue down?

Is there a reason why PGO must be enabled? I thought it's just an optimization.
But yeah, hopefully this solves the issue. There's "prior art" after all: https://developercommunity.visualstudio.com/t/Bug-in-x86-build-inlining-destructor-wit/10658747

@DHowett DHowett merged commit 408f3e2 into main Aug 20, 2024
@DHowett DHowett deleted the dev/duhowett/nopego branch August 20, 2024 19:15
DHowett added a commit that referenced this pull request Aug 21, 2024
@DHowett
Disable PGO for Release builds
ba22a0c 
Same justification as #17749.
@DHowett DHowett mentioned this pull request Aug 21, 2024
Merged
DHowett added a commit that referenced this pull request Aug 21, 2024
@DHowett
Disable PGO for Release builds (#17765)
628e99f 
Same justification as #17749.

We will revert this when either OneBranch Custom Pools become
fit-for-purpose or they upgrade to VS 17.11. Or the heat death of the
universe.
DHowett added a commit that referenced this pull request Aug 21, 2024
@DHowett
Disable PGO for Release builds (#17765)
8e7137d 
Same justification as #17749.

We will revert this when either OneBranch Custom Pools become
fit-for-purpose or they upgrade to VS 17.11. Or the heat death of the
universe.

(cherry picked from commit 628e99f)
Service-Card-Id: PVTI_lADOAF3p4s4AmhmszgSGCaA
Service-Version: 1.21
DHowett added a commit that referenced this pull request Jan 29, 2026
@DHowett
Revert "Disable PGO for nightly builds (#17749)"
0741d17 
This reverts commit 408f3e2.
DHowett added a commit that referenced this pull request Jan 29, 2026
@DHowett
Revert "Disable PGO for nightly builds (#17749)" (#19816)
cdf4bd9 
This reverts commit 408f3e2.

Now that we have #19810, it works again!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lhecker lhecker lhecker approved these changes

@zadjii-msft zadjii-msft zadjii-msft approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@DHowett @zadjii-msft @lhecker