Skip to content

build: make the PGO build work again; upgrade nuget #19810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
DHowett merged 3 commits into from
Jan 29, 2026
Merged

build: make the PGO build work again; upgrade nuget #19810

DHowett merged 3 commits into from
Jan 29, 2026
+20 −16

Conversation

@DHowett
Copy link
Member

@DHowett DHowett commented Jan 29, 2026

Two main changes:

  • the build was failing for ARM64 because the build agents run out of memory downloading artifacts; this is a known issue that nobody cares to fix (and it pertains to using the x64 emulated agent host on native arm64 machines)
    • deleting the PDBs shrinks the build output by 2500MB :P
  • we had to switch to a new type of identity for publishing nuget packages to our cross-org feed

I've verified that we get counts and can even produce final PGO count packages for both architectures!

@DHowett DHowett changed the title build: make the PGO build work again build: make the PGO build work again; upgrade nuget Jan 29, 2026
@DHowett DHowett force-pushed the dev/duhowett/make-the-pgo-publishing-step-work-again branch from a4dee3e to 840a6d6 Compare January 29, 2026 03:23
@DHowett DHowett enabled auto-merge (squash) January 29, 2026 17:43
carlos-zamora
carlos-zamora approved these changes Jan 29, 2026
View reviewed changes
Copy link
Member

@carlos-zamora carlos-zamora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@DHowett DHowett merged commit 8f3d1d8 into main Jan 29, 2026
27 checks passed
@DHowett DHowett deleted the dev/duhowett/make-the-pgo-publishing-step-work-again branch January 29, 2026 20:44
@DHowett DHowett mentioned this pull request Jan 29, 2026
Merged
DHowett added a commit that referenced this pull request Jan 29, 2026
@DHowett
Revert "Disable PGO for nightly builds (#17749)" (#19816)
cdf4bd9 
This reverts commit 408f3e2.

Now that we have #19810, it works again!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carlos-zamora carlos-zamora carlos-zamora approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@DHowett @carlos-zamora