Add initial rendering-only BiDi support to AtlasEngine#20377
Draft
i7xre wants to merge 3 commits into
Draft
Conversation
Author
|
@microsoft-github-policy-service agree |
Member
|
Coordinate your efforts with #20159. Make sure that you aren't making the same mistakes as we have discussed with them. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds initial rendering-only bidirectional text support to AtlasEngine.
The change improves visual ordering and shaping for RTL scripts such as Arabic, Persian, and Hebrew by using DirectWrite BiDi analysis in the Atlas text shaping path, ordering visual spans by resolved embedding levels, and emitting RTL shaped clusters in visual order.
This intentionally does not implement full terminal BiDi support. The scope of this PR is limited to rendered text ordering inside AtlasEngine.
Implementation
IDWriteTextAnalyzer::AnalyzeBidi.Validation
Built locally:
src/renderer/atlas/atlas.vcxprojValidated manually using a local Windows Terminal Dev package with:
Known Limitations
This is intentionally a rendering-only implementation.
The following are out of scope for this PR:
Current known issues:
Follow-up Work
Future work should address:
This PR is intended as an initial rendering improvement and as a foundation for future BiDi work, rather than a complete RTL terminal implementation.