(GH-2044) Updated readme to include Chocolatey package #2084
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gep13
suggested changes
Jul 25, 2019
ghost
added
the
Needs-Author-Feedback
DHowett-MSFT
approved these changes
Jul 25, 2019
Contributor
DHowett-MSFT
left a comment
DHowett-MSFT
left a comment
There was a problem hiding this comment.
I'm fine with this regardless of the use of update or upgrade. Thanks for preparing the package and the documentation update!
Contributor
Author
|
Let me fix that real quick. |
ghost
removed
the
Needs-Author-Feedback
Contributor
Author
|
@DHowett-MSFT I don't know how this PR could break the build. Could you please verify? |
zadjii-msft
approved these changes
Jul 25, 2019
Co-Authored-By: Mike Griese <migrie@microsoft.com>
Member
|
Oh you didn't break the build. We've been running into some infrastructure issues with our build lab, so I wouldn't be worried about that. |
Contributor
Author
|
@zadjii-msft I have committed your suggestion. |
miniksa
approved these changes
Jul 25, 2019
Member
I'm correcting that in #2096 to unblock everyone. |
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
@miniksa Thank you! |
mcpiroman
pushed a commit
to mcpiroman/terminal
that referenced
this pull request
Jul 26, 2019
…osoft#2084) * (microsoftGH-2044) Updated readme to include Chocolatey package Co-Authored-By: Mike Griese <migrie@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Updated documentation regarding the Chocolatey package installation
References
#2044
PR Checklist
Detailed Description of the Pull Request / Additional comments
Updated documentation
Validation Steps Performed
N/A