Remove static analysis builds because they're running out of disk space. #2096
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 25, 2019
Merged
DHowett-MSFT
approved these changes
Jul 25, 2019
Contributor
DHowett-MSFT
left a comment
DHowett-MSFT
left a comment
There was a problem hiding this comment.
Shall I be the guy? Want to whack a TODO and a followup issue to re-enable these?
Contributor
|
This is annoying to see. |
Member
Author
I know, but I need to merge things today. I want to get them back online. |
Member
Author
Yes, I'll write one. |
adiviness
approved these changes
Jul 25, 2019
zadjii-msft
approved these changes
Jul 25, 2019
Contributor
I understand. I approved but it doesn't hold the same weight it used to. You'll need a real 2nd approver. |
mcpiroman
pushed a commit
to mcpiroman/terminal
that referenced
this pull request
Jul 26, 2019
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@DHowett-MSFT has a thread with the relevant people trying to sort this whole thing out.
But in the meantime, the static analysis builds are low value and are blocking actual work from happening.
So I commented them out for now.