Fixed duplicate line in TermControl (#732) #739
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mKay00
changed the title
zadjii-msft
approved these changes
May 13, 2019
Member
zadjii-msft
left a comment
zadjii-msft
left a comment
There was a problem hiding this comment.
Out of curiousity, what happens when you change the line to
swapChainPanel.SetValue(FrameworkElement::VerticalAlignmentProperty(),
box_value(VerticalAlignment::Stretch));
zadjii-msft
added
Area-TerminalControl
Contributor
Author
|
Actually nothing, since the default value seems to be Stretch for both Vertical and Horizontal:
So, I guess I can delete both lines and commit again? |
Member
|
Oh, then yea go ahead! |
|
|
zadjii-msft
approved these changes
May 13, 2019
DHowett-MSFT
approved these changes
May 13, 2019
Contributor
|
Thanks! |
ObsidianPhoenix
pushed a commit
to ObsidianPhoenix/Terminal
that referenced
this pull request
May 15, 2019
* Fixed duplicate line in TermControl microsoft#732 * Deleted lines, because values were unnecessarily set to default values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I deleted the duplicate line in TermControl mentioned in #732