Directory not found error after upgrading from 3.7.3 -> 3.8+ versions

[shangeet]

System.IO.DirectoryNotFoundException: Could not find a part of the path after upgrading framework version

After upgrading to any version >= 3.8, the build fails with a Directory not found exception on the SelfRegisteredExtensionsSourcePath task:

         SelfRegisteredExtensionsSourcePath: '[Path to project redacted]\objd\A
         MD64\'
         Language: 'C#'
         TestingPlatformExtensionFullTypeNames:
          Hook UID: '98058041-B5B6-4A75-9834-58E6DF796A22' DisplayName: 'Microsoft.Testing.Extensions.Telemetry' TypeFu
         llName: 'Microsoft.Testing.Extensions.Telemetry.TestingPlatformBuilderHook'
          Hook UID: '8214564B-6107-422D-8A82-462F97602287' DisplayName: 'Microsoft.Testing.Platform.MSBuild' TypeFullNa
         me: 'Microsoft.Testing.Platform.MSBuild.TestingPlatformBuilderHook'

         SelfRegisteredExtensions source:
         '//------------------------------------------------------------------------------
         // <auto-generated>
         //     This code was generated by Microsoft.Testing.Platform.MSBuild
         // </auto-generated>
         //------------------------------------------------------------------------------

         namespace Microsoft.PrivilegeManagement.Test.CloudTestCommon
         {
             [global::System.Diagnostics.CodeAnalysis.ExcludeFromCodeCoverage]
             internal static class SelfRegisteredExtensions
             {
                 public static void AddSelfRegisteredExtensions(this global::Microsoft.Testing.Platform.Builder.ITestAp
         plicationBuilder builder, string[] args)
                 {
                     Microsoft.Testing.Extensions.Telemetry.TestingPlatformBuilderHook.AddExtensions(builder, args);
                 Microsoft.Testing.Platform.MSBuild.TestingPlatformBuilderHook.AddExtensions(builder, args);
                 }
             }
         }'

Impacts version >= 3.8

Steps To Reproduce

Expected behavior

Build Succeeds

Actual behavior

Build fails with directory not found exception.

The "TestingPlatformSelfRegisteredExtensions" task failed unexpectedly. [Path to project readacted]\CloudTestCommon.csproj]
       C:\CxCache\Microsoft.Testing.Platform.MSBuild.1.6.0\buildMultiTargeting\Microsoft.Testing.Platform.MSBuild.targe
       ts(201,5): error MSB4018: System.IO.DirectoryNotFoundException: Could not find a part of the path '[Path to project redacted]\objd\AMD64\'. [Path To project redacted]\CloudTestCommon.csproj]

Additional context

My csproj file contains a reference to both the framework and adapter targets.

  <Import Project="$(SRCROOT)\Targets\Generated\MSTest.TestFramework.targets" />
  <Import Project="$(SRCROOT)\Targets\Generated\MSTest.TestAdapter.targets" />

[Youssef1313]

@shangeet Thanks for reporting this.

First, can you please make sure you are using 3.8.2 and not 3.8.0? If the issue happens with 3.8.2, can you please provide us a repro, or a binlog? Thank you!

[shangeet]

Hi @Youssef1313 ,

I have also confirmed that this is also happening on 3.8.2. Downgrading back to 3.7.3 version works as expected.

As for a repro, I have seen the issue on a single project being upgrading with the 3.8.2 version. No other changes were made. I am unfortunately not able to give a binlog due to company policy.

[Youssef1313]

@shangeet I'm curious, was this resolved somehow?

[shangeet]

Hi, yes, sorry.

I had to change the order of the import statements. I'm not sure why this changed in version 3.8.2, but it was looking for the directory before it was created. The solution was to move the import statements to the end of the csproj file and have them execute after everything else.

[Youssef1313]

I'm curious why do you need to manually import the package targets? You should be consuming the package via NuGet, and then the targets files are imported automatically for you in the correct/expected order.

[shangeet]

@Youssef1313 The company I work for has an internal tool that imports the nuget .targets manually, and then we reference those .targets directly. So the csproj file basically has:

<Import Project="$(SRCROOT)\Targets\Generated\MSTest.TestFramework.targets" />

However, it turns out there's another issue. Even though changing the import locations fixed the build issues, our tests are no longer being discovered properly.

I see there was a change 2 weeks or so ago regarding the error I saw earlier in SelfRegisteredExtensionsSourcePath.

#5056

Do I need to set some sort of property in my .csproj file?

I will reopen this temporarily.