MTP2 response file parser cannot parse arguments with quotes and spaces

[MaceWindu]

Describe the bug

It is not possible to put large test filters to rsp files if they have spaces and quotes

Steps To Reproduce

Test (using NUnit adapter)

using NUnit.Framework;

public class Tests
{
    [Test]
    public void Test([Values("test value")] string arg)
    {
        Assert.Pass();
    }
}

Command line (works):

MTP2.exe --filter "FullyQualifiedName=Tests.Test\(\"test value\"\)"

RSP file

--filter "FullyQualifiedName=Tests.Test\(\"test value\"\)"

Calling with rsp file results in filter parsed as multiple arguments

MTP2.exe @rsp
Option '--filter' from provider 'NUnit' (UID: NUnitExtension) expects at most 1 arguments

Expected behavior

works with rsp

Actual behavior

Error

Option '--filter' from provider 'NUnit' (UID: NUnitExtension) expects at most 1 arguments

[MihuBot]

I'm a bot. Here is a possible related and/or duplicate issue (I may be wrong):

• MTP command-line parsing is possibly buggy #7039

[MaceWindu]

@MihuBot, close, but no cigar.
It doesn't change ResponseFileHelper, which returns

[Youssef1313]

The ResponseFileHelper implementation is a copy from System.CommandLine implementation. @jonsequitur Is there no way to escape double quotes in a response file? Is that expected?

[nohwnd]

There is one more thing to note.

The example provided is run via cmdline, and escaped for the commandline, where \" will become " after parsing.

In powershell \" won't become just ", so instead you need to specify: nunit16.exe --filter 'FullyQualifiedName=Tests.Test\("test value"\)', from which the powershell parser will eat the single quotes '`.

So filter syntax needed literally is: --filter FullyQualifiedName=Tests.Test\("test value"\), with the escapes for ( but not for quotes. This is imho what should be placed in the response file.

However the response file parser (we copied from system.commandline) eats the quotes in the response file, providing just --filter FullyQualifiedName=Tests.Test\(test value\) to the program.