Remove extra space

[nohwnd]

Looks like the code is there since forever, and would always add a single extra space before the first "at".

Fix #5152

[nohwnd]

not sure why the single space ends up being much larger shift in the ansi code output.

this is before removing the append:

[nohwnd]

also fixes normal terminal (with --no-ansi)

[Youssef1313]

Could you make a test with VSTest as well?

[nohwnd]

It does not fix vstest, but I can see the same problem there with nunit. (while of course nunit is fine in mtp)

[Youssef1313]

It does not fix vstest

Not sure what do you mean? What is the behavior when using VSTest before and after the change. I was expecting VSTest to probably be having the correct spacing already, and gets broken with the change. That's the guess I have.

[nohwnd]

vstest output has incorrect spacing before and after the change, both for mstest and nunit.

[Youssef1313]

Nice. That was unexpected to me 😄

[nohwnd]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[nohwnd]

/backport to rel/3.8

[github-actions]

Started backporting to rel/3.8: https://github.com/microsoft/testfx/actions/runs/13894905574

[github-actions]

@nohwnd backporting to rel/3.8 failed, the patch most likely resulted in conflicts:

$ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch

Applying: Remove extra space
Applying: Remove extra space
Applying: Fix tests
Using index info to reconstruct a base tree...
M	test/UnitTests/MSTestAdapter.UnitTests/Execution/TestAssemblyInfoTests.cs
M	test/UnitTests/MSTestAdapter.UnitTests/Execution/TestClassInfoTests.cs
M	test/UnitTests/MSTestAdapter.UnitTests/Execution/TestMethodInfoTests.cs
M	test/UnitTests/MSTestAdapter.UnitTests/Extensions/ExceptionExtensionsTests.cs
Falling back to patching base and 3-way merge...
Auto-merging test/UnitTests/MSTestAdapter.UnitTests/Extensions/ExceptionExtensionsTests.cs
CONFLICT (content): Merge conflict in test/UnitTests/MSTestAdapter.UnitTests/Extensions/ExceptionExtensionsTests.cs
Auto-merging test/UnitTests/MSTestAdapter.UnitTests/Execution/TestMethodInfoTests.cs
CONFLICT (content): Merge conflict in test/UnitTests/MSTestAdapter.UnitTests/Execution/TestMethodInfoTests.cs
Auto-merging test/UnitTests/MSTestAdapter.UnitTests/Execution/TestClassInfoTests.cs
CONFLICT (content): Merge conflict in test/UnitTests/MSTestAdapter.UnitTests/Execution/TestClassInfoTests.cs
Auto-merging test/UnitTests/MSTestAdapter.UnitTests/Execution/TestAssemblyInfoTests.cs
CONFLICT (content): Merge conflict in test/UnitTests/MSTestAdapter.UnitTests/Execution/TestAssemblyInfoTests.cs
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0003 Fix tests
Error: The process '/usr/bin/git' failed with exit code 128

NOTE: A PR will be created, but needs to be revised manually!