Fix codefix of analyzer for flowing cancellation token#6239
Merged
Evangelink merged 6 commits intomainfrom Jul 31, 2025
Merged
Conversation
…ixer Co-authored-by: Evangelink <11340282+Evangelink@users.noreply.github.com>
Co-authored-by: Evangelink <11340282+Evangelink@users.noreply.github.com>
Co-authored-by: Evangelink <11340282+Evangelink@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix codefix of analyzer for flowing cancellation token
Fix codefix of analyzer for flowing cancellation token
Jul 30, 2025
Evangelink
reviewed
Jul 30, 2025
- Implement missing HasTestContextProperty and AddTestContextProperty methods - Fix parameter list syntax error in AddTestContextParameterToMethod - Fix KeyValuePair deconstruction in foreach loop - Add required using statements for System.Linq and System.Collections.Generic - Make helper methods internal static for access from FixAllProvider Co-authored-by: Evangelink <11340282+Evangelink@users.noreply.github.com>
ff7558f to
cff832d
Compare
Evangelink
approved these changes
Jul 31, 2025
Member
|
/backport to rel/3.10 |
Contributor
|
Started backporting to rel/3.10: https://github.com/microsoft/testfx/actions/runs/16642926022 |
nohwnd
approved these changes
Jul 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
FlowTestContextCancellationTokenFixerwas generating invalid code whenTestContextwas not in scope, causing compilation errors (CS0103). The codefix would generate code liketestContext.CancellationTokenSource.Tokeneven when notestContextvariable existed.Changes Made
Custom FixAllProvider Implementation
FlowTestContextCancellationTokenFixAllProviderusingDocumentBasedFixAllProviderpatternTestContextproperty is added only once per class when multiple fixes are appliedEnhanced Individual Codefix Logic
ApplyFixWithTestContextAsyncto ensureTestContextavailability before applying fixesClassCleanup,AssemblyCleanup): addsTestContext testContextparameterpublic TestContext TestContext { get; set; }property when missingTestContextreferences when already availableBefore (broken):
After (fixed):
The fix ensures generated code always compiles successfully while making minimal necessary changes to add
TestContextonly when needed.Fixes #6237.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.