Fix race in TestContextImplementation#6249
Merged
Evangelink merged 2 commits intomainfrom Jul 30, 2025
Merged
Conversation
Member
Author
|
/backport to rel/3.10 |
Contributor
|
Started backporting to rel/3.10: https://github.com/microsoft/testfx/actions/runs/16621904510 |
Evangelink
previously approved these changes
Jul 30, 2025
Member
Author
|
/backport to rel/3.10 |
Contributor
|
Started backporting to rel/3.10: https://github.com/microsoft/testfx/actions/runs/16623163261 |
mariam-abdulla
approved these changes
Jul 30, 2025
Youssef1313
added a commit
that referenced
this pull request
Jul 30, 2025
…ort to rel/3.10) (#6250) Co-authored-by: Youssef1313 <youssefvictor00@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hopefully fixes #6246
Ideally, we should also set a flag in TestContext before we call
GetOutorGetError, and have theConsole[Out|Error]Routercheck it before writing. If the flag is true already, write to original console out/err.