Fix ApplicationStateGuard filename - rename Class1.cs to ApplicationStateGuard.cs#6298
Merged
Fix ApplicationStateGuard filename - rename Class1.cs to ApplicationStateGuard.cs#6298
Conversation
Co-authored-by: nohwnd <5735905+nohwnd@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] ApplicationStateGuard filename is wrong
Fix ApplicationStateGuard filename - rename Class1.cs to ApplicationStateGuard.cs
Aug 4, 2025
Youssef1313
reviewed
Aug 4, 2025
src/TestFramework/TestFramework/Internal/ApplicationStateGuard.cs
Outdated
Show resolved
Hide resolved
Youssef1313
reviewed
Aug 4, 2025
src/TestFramework/TestFramework/Internal/ApplicationStateGuard.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Youssef1313 <31348972+Youssef1313@users.noreply.github.com>
nohwnd
approved these changes
Aug 4, 2025
Youssef1313
approved these changes
Aug 4, 2025
drognanar
approved these changes
Aug 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ApplicationStateGuardclass in the TestFramework project was incorrectly placed in a file namedClass1.cs. This violates .NET naming conventions where the filename should match the class name.Changes Made
src/TestFramework/TestFramework/Internal/Class1.cstoApplicationStateGuard.csMicrosoft.VisualStudio.TestTools.UnitTestingBefore
After
This change brings the TestFramework's
ApplicationStateGuardimplementation in line with the naming conventions used by otherApplicationStateGuardclasses throughout the codebase (in Platform, Analyzers, and Adapter projects). The existing usage inAssert.AreEqual.cscontinues to work unchanged since both files are in the same namespace.Fixes #6297.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.