Skip to content

Revert Assert.That obsoletion#6323

Merged
Youssef1313 merged 1 commit intomainfrom
dev/ygerges/revert-break
Aug 7, 2025
Merged

Revert Assert.That obsoletion#6323
Youssef1313 merged 1 commit intomainfrom
dev/ygerges/revert-break

Conversation

@Youssef1313
Copy link
Member

Reverts #5811 per user feedback.

nohwnd
nohwnd previously approved these changes Aug 7, 2025
drognanar
drognanar previously approved these changes Aug 7, 2025
@Youssef1313 Youssef1313 enabled auto-merge (squash) August 7, 2025 07:25
@Youssef1313 Youssef1313 dismissed stale reviews from drognanar and nohwnd via 1cb8b7b August 7, 2025 07:37
@Youssef1313
Copy link
Member Author

/backport to rel/3.10

@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2025

Started backporting to rel/3.10: https://github.com/microsoft/testfx/actions/runs/16798273530

@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2025

@Youssef1313 backporting to rel/3.10 failed, the patch most likely resulted in conflicts:

$ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch

Applying: Revert Assert.That obsoletion
Using index info to reconstruct a base tree...
M	src/TestFramework/TestFramework/PublicAPI/PublicAPI.Unshipped.txt
Falling back to patching base and 3-way merge...
Auto-merging src/TestFramework/TestFramework/PublicAPI/PublicAPI.Unshipped.txt
CONFLICT (content): Merge conflict in src/TestFramework/TestFramework/PublicAPI/PublicAPI.Unshipped.txt
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 Revert Assert.That obsoletion
Error: The process '/usr/bin/git' failed with exit code 128

NOTE: A PR will be created, but needs to be revised manually!

@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2025

@Youssef1313 backporting to rel/3.10 failed, the patch most likely resulted in conflicts:

$ git am --continue

Applying: Revert Assert.That obsoletion
Applying: Fix more
Using index info to reconstruct a base tree...
M	src/TestFramework/TestFramework/PublicAPI/PublicAPI.Shipped.txt
M	src/TestFramework/TestFramework/PublicAPI/PublicAPI.Unshipped.txt
Falling back to patching base and 3-way merge...
Auto-merging src/TestFramework/TestFramework/PublicAPI/PublicAPI.Shipped.txt
CONFLICT (content): Merge conflict in src/TestFramework/TestFramework/PublicAPI/PublicAPI.Shipped.txt
Auto-merging src/TestFramework/TestFramework/PublicAPI/PublicAPI.Unshipped.txt
CONFLICT (content): Merge conflict in src/TestFramework/TestFramework/PublicAPI/PublicAPI.Unshipped.txt
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0002 Fix more
Error: The process '/usr/bin/git' failed with exit code 128

NOTE: A PR will be created, but needs to be revised manually!

@Youssef1313 Youssef1313 force-pushed the dev/ygerges/revert-break branch from 1cb8b7b to 789f977 Compare August 7, 2025 07:44
@Youssef1313
Copy link
Member Author

/backport to rel/3.10

@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2025

Started backporting to rel/3.10: https://github.com/microsoft/testfx/actions/runs/16798345673

@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2025

@Youssef1313 backporting to rel/3.10 failed, the patch most likely resulted in conflicts:

$ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch

Applying: Revert Assert.That obsoletion
Using index info to reconstruct a base tree...
M	src/TestFramework/TestFramework/PublicAPI/PublicAPI.Unshipped.txt
Falling back to patching base and 3-way merge...
Auto-merging src/TestFramework/TestFramework/PublicAPI/PublicAPI.Unshipped.txt
CONFLICT (content): Merge conflict in src/TestFramework/TestFramework/PublicAPI/PublicAPI.Unshipped.txt
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 Revert Assert.That obsoletion
Error: The process '/usr/bin/git' failed with exit code 128

NOTE: A PR will be created, but needs to be revised manually!

@Youssef1313 Youssef1313 merged commit 6f57c7d into main Aug 7, 2025
8 checks passed
@Youssef1313 Youssef1313 deleted the dev/ygerges/revert-break branch August 7, 2025 09:10
Youssef1313 added a commit that referenced this pull request Aug 7, 2025
…el/3.10) (#6324)

Co-authored-by: Youssef1313 <youssefvictor00@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants