Skip to content

Conversation

@Evangelink
Copy link
Member

@Evangelink Evangelink commented Dec 16, 2025

Partially fixes #5366. Now we need some work on the frameworks side.

Testing with TUnit as in linked ticket:
image

Testing with MSTest:
image

I haven't added some acceptance test because we need bigger machinery (workload + winget tool installed).

Simply calling dotnet run doesn't work but I don't know enough wasi to see what's missing:
Uploading image.png…

@Evangelink Evangelink enabled auto-merge (squash) December 16, 2025 13:58
@Evangelink Evangelink changed the title MTP now run correctly on wasi MTP runs correctly on wasi Dec 16, 2025
@Evangelink Evangelink merged commit 9bb25ab into main Dec 16, 2025
11 checks passed
@Evangelink Evangelink deleted the dev/amauryleve/wasi branch December 16, 2025 15:54
}
}

private static string ComputeNonCryptographicHash(string text)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wasi is still experimental right? Why do we care too much about it early? Regardless, I would avoid using non-cryptographic hash here. Either we disable this code path on WASI (which is telemetry only I think), or implement a managed Sha256 and use it here.

@Youssef1313
Copy link
Member

@Evangelink I tried this but it doesn't work and I don't see any viable workaround for that on our side.

Unhandled Exception:
System.PlatformNotSupportedException: Arg_PlatformNotSupported
   at System.Threading.Tasks.Task.InternalWaitCore(Int32 millisecondsTimeout, CancellationToken cancellationToken)
   at System.Threading.Tasks.Task.InternalWait(Int32 millisecondsTimeout, CancellationToken cancellationToken)
   at Program.<Main>(String[] args)

@Evangelink
Copy link
Member Author

That's the error I was mentioning above and it's not produced by the platform afaik, so we need to fix MSTest (also TUnit as per screenshot)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow running on wasm platform

4 participants