Fix stack trace assertions for Release mode on .NET Framework #7317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use [MethodImpl(NoInlining)] on .NET Framework to prevent JIT from inlining small methods, which would remove stack frames. The assertions now check for the DummyTestClass method frames instead of lambda frames. Fixes #5109
Youssef1313
reviewed
Feb 3, 2026
test/UnitTests/MSTestAdapter.PlatformServices.UnitTests/Execution/TestMethodInfoTests.cs
Outdated
Show resolved
Hide resolved
Youssef1313
reviewed
Feb 3, 2026
test/UnitTests/MSTestAdapter.PlatformServices.UnitTests/Execution/TestMethodInfoTests.cs
Show resolved
Hide resolved
Youssef1313
approved these changes
Feb 3, 2026
Member
Youssef1313
left a comment
Youssef1313
left a comment
There was a problem hiding this comment.
I'm concerned about not fully knowing what have changed over time for these tests. But given this is not any product change, I'm approving.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use [MethodImpl(NoInlining)] on .NET Framework to prevent JIT from inlining small methods, which would remove stack frames. The assertions now check for the DummyTestClass method frames instead of lambda frames.
Fixes #5109